Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a utility to map Windows theme colors to React95 theme objects. #212

Closed
tpenguinltg opened this issue Nov 10, 2020 · 3 comments · Fixed by #221
Closed

Create a utility to map Windows theme colors to React95 theme objects. #212

tpenguinltg opened this issue Nov 10, 2020 · 3 comments · Fixed by #221
Labels

Comments

@tpenguinltg
Copy link
Contributor

This utility be a function that takes in a object with key-value pairs corresponding to Windows theme color properties and maps them into a React95 theme object. The values in the input object should be a valid CSS color and is mapped untouched to the React95 theme object.

Example input:

{
  ButtonAlternateFace: '#c0c0c0',
  ButtonDkShadow: '#404040',
  ButtonFace: '#d4d0c8',
  ButtonHilight: '#ffffff',
  ButtonLight: '#d4d0c8',
  ButtonShadow: '#808080',
  ButtonText: '#000000',
  ActiveBorder: '#d4d0c8',
  AppWorkspace: '#808080',
  Background: '#3a6ea5',
  InactiveBorder: '#d4d0c8',
  Scrollbar: '#d4d0c8',
  Window: '#ffffff',
  WindowFrame: '#000000',
  WindowText: '#000000',
  ActiveTitle: '#0a246a',
  GradientActiveTitle: '#a6caf0',
  GradientInactiveTitle: '#c0c0c0',
  InactiveTitle: '#808080',
  InactiveTitleText: '#d4d0c8',
  TitleText: '#ffffff',
  Menu: '#d4d0c8',
  MenuBar: '#c0c0c0',
  MenuHilight: '#000080',
  MenuText: '#000000',
  GrayText: '#808080',
  Hilight: '#0a246a',
  HilightText: '#ffffff',
  HotTrackingColor: '#000080',
  InfoText: '#000000',
  InfoWindow: '#ffffe1',
}

To determine: Which Windows theme properties map to which React95 theme properties.

This should help ease the transition to v4 as one of the goals listed in #210 is to match color names.

@tpenguinltg
Copy link
Contributor Author

I've slowly made progress on this and it's almost ready to go. I just need to add tests and do any necessary clean up when I get a chance, and then I can put up a pull request when it's ready.

@arturbien
Copy link
Member

@tpenguinltg that's awesome! <3

@arturbien
Copy link
Member

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants