Skip to content

Commit dcef7a7

Browse files
follow spec for size constraint and infinitely growable flag set
1 parent 7a51319 commit dcef7a7

2 files changed

Lines changed: 204 additions & 186 deletions

File tree

tests/grid/TrackSizingTest.cpp

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -344,8 +344,7 @@ TEST_F(TrackSizingTest, distributeSpaceToTracksBaseSize_basic_distribution) {
344344
Dimension::Width,
345345
affectedTracks,
346346
spannedTracks,
347-
200.0f,
348-
SpaceDistributionPhase::AccommodateMinimumContribution
347+
200.0f
349348
);
350349

351350
// Each track should get 100px
@@ -389,8 +388,7 @@ TEST_F(TrackSizingTest, distributeSpaceToTracksBaseSize_with_growth_limits) {
389388
Dimension::Width,
390389
affectedTracks,
391390
spannedTracks,
392-
200.0f,
393-
SpaceDistributionPhase::AccommodateMinimumContribution
391+
200.0f
394392
);
395393

396394
// First track should be limited to its growth limit (80px)
@@ -435,8 +433,7 @@ TEST_F(TrackSizingTest, distributeSpaceToTracksBaseSize_no_space_to_distribute)
435433
Dimension::Width,
436434
affectedTracks,
437435
spannedTracks,
438-
200.0f,
439-
SpaceDistributionPhase::AccommodateMinimumContribution
436+
200.0f
440437
);
441438

442439
// Tracks should remain unchanged
@@ -478,8 +475,7 @@ TEST_F(TrackSizingTest, distributeSpaceToTracksBaseSize_single_track) {
478475
Dimension::Width,
479476
affectedTracks,
480477
spannedTracks,
481-
150.0f,
482-
SpaceDistributionPhase::AccommodateMinimumContribution
478+
150.0f
483479
);
484480

485481
EXPECT_EQ(columnTracks[0].baseSize, 150.0f);
@@ -532,7 +528,8 @@ TEST_F(TrackSizingTest, distributeSpaceToTracksGrowthLimit_basic_distribution) {
532528
Dimension::Width,
533529
affectedTracks,
534530
spannedTracks,
535-
300.0f // Total contribution: 300px, currently have 100px base size
531+
300.0f,
532+
true
536533
);
537534

538535
// Each track's growth limit should be set (was INFINITY)
@@ -583,7 +580,8 @@ TEST_F(TrackSizingTest, distributeSpaceToTracksGrowthLimit_not_infinitely_growab
583580
Dimension::Width,
584581
affectedTracks,
585582
spannedTracks,
586-
300.0f
583+
300.0f,
584+
true
587585
);
588586

589587
// First track shouldn't grow (not infinitely growable)
@@ -635,8 +633,7 @@ TEST_F(TrackSizingTest, distributeSpaceToFlexibleTracks_sum_gte_1) {
635633
Dimension::Width,
636634
affectedTracks,
637635
spannedTracks,
638-
300.0f,
639-
SpaceDistributionPhase::AccommodateMinimumContribution
636+
300.0f
640637
);
641638

642639
// First track: 300 * (1/3) = 100px
@@ -681,8 +678,7 @@ TEST_F(TrackSizingTest, distributeSpaceToFlexibleTracks_sum_lt_1) {
681678
Dimension::Width,
682679
affectedTracks,
683680
spannedTracks,
684-
300.0f,
685-
SpaceDistributionPhase::AccommodateMinimumContribution
681+
300.0f
686682
);
687683

688684
// Proportional space = 300 * 0.5 = 150px
@@ -733,8 +729,7 @@ TEST_F(TrackSizingTest, distributeSpaceToFlexibleTracks_with_existing_base) {
733729
Dimension::Width,
734730
affectedTracks,
735731
spannedTracks,
736-
300.0f,
737-
SpaceDistributionPhase::AccommodateMinimumContribution
732+
300.0f
738733
);
739734

740735
// Space to distribute = 300 - 100 = 200px
@@ -777,8 +772,7 @@ TEST_F(TrackSizingTest, distributeSpaceToFlexibleTracks_single_track) {
777772
Dimension::Width,
778773
affectedTracks,
779774
spannedTracks,
780-
250.0f,
781-
SpaceDistributionPhase::AccommodateMinimumContribution
775+
250.0f
782776
);
783777

784778
EXPECT_FLOAT_EQ(columnTracks[0].baseSize, 250.0f);

0 commit comments

Comments
 (0)