Clear AnimatedPropsRegistry on surface stop (#56485)#56485
Closed
zeyap wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101354994. |
zeyap
force-pushed
the
export-D101354994
branch
from
a501e6f to
ddbb31b
Compare
meta-codesync
Bot
changed the title
zeyap
force-pushed
the
export-D101354994
branch
12 times, most recently
from
3b0b562 to
7258050
Compare
Summary: Pull Request resolved: #56485 ## Changelog: [Internal] [Fixed] - Clear AnimatedPropsRegistry on surface stop When `useSharedAnimatedBackend` is enabled, the `AnimatedPropsRegistry` accumulates `SurfaceContext` entries (containing `shared_ptr<ShadowNodeFamily>` and `PropsSnapshot` data) for each surface that has animated views. These entries are never cleaned up when a surface is destroyed via `UIManager::stopSurface()`, because that method only calls the legacy `stopSurfaceForAnimationDelegate()` — the shared backend's registry is untouched. We also see increased `RetryableMountingLayerException` errors in production which stack trace shows there are mount items committing to surface that no longer exists. This change: 1. Adds `animationBackend_->clearRegistry(surfaceId)` to `UIManager::stopSurface()` 2. Changes `AnimatedPropsRegistry::clear()` to fully erase the `surfaceContexts_` map entry instead of just clearing its contents Reviewed By: christophpurrer Differential Revision: D101354994
zeyap
force-pushed
the
export-D101354994
branch
from
7258050 to
b452798
Compare
|
This pull request has been merged in 1433e43. |
Collaborator
|
This pull request was successfully merged by @zeyap in 1433e43 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Fixed] - Clear AnimatedPropsRegistry on surface stop
When
useSharedAnimatedBackendis enabled, theAnimatedPropsRegistryaccumulatesSurfaceContextentries (containingshared_ptr<ShadowNodeFamily>andPropsSnapshotdata) for each surface that has animated views. These entries are never cleaned up when
a surface is destroyed via
UIManager::stopSurface(), because that method only callsthe legacy
stopSurfaceForAnimationDelegate()— the shared backend's registry is untouched.We also see increased
RetryableMountingLayerExceptionerrors in production which stack traceshows there are mount items committing to surface that no longer exists.
This change:
animationBackend_->clearRegistry(surfaceId)toUIManager::stopSurface()AnimatedPropsRegistry::clear()to fully erase thesurfaceContexts_mapentry instead of just clearing its contents
Reviewed By: christophpurrer
Differential Revision: D101354994