refactor: migrate ReactTextView to kotlin#54219
Closed
FouadMagdy01 wants to merge 3 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
Author
|
Hey @cipolleschi , Can you please take a look on that ? |
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
react-native-bot
removed
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In order to align with react-native's roadmap to migrate android codebase to kotlin instead of java
i made this migration to the
TextView,The only remaining view to migrate to kotlin as most of other views have been migrated latelyRemoved ReactTextView.java
Added ReactTextView.kt
Changelog:
[ANDROID] [CHANGED] - Migrated ReactTextView from Java to Kotlin
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
Test Plan:
Run
yarn androidto run the RNTester app and navigate to the Text showcase screen to verify everything is working correctly.Tested all text features including:
All functionality works exactly as before the migration.