Skip to content

Commit e78afea

Browse files
coadometa-codesync[bot]
authored andcommitted
Exclude UnstabeLegacy symbols from stable C++ API snapshot (#56242)
Summary: Pull Request resolved: #56242 Excluded symbols that contain "UnstableLegacy" from public stable C++ API snapshot, that is `UnstableLegacyViewManagerAutomaticComponentDescriptor` and `UnstableLegacyViewManagerInteropComponentDescriptor`. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D98317003 fbshipit-source-id: deb4631a26ecb138007cf4958dbabb57ef3739cc
1 parent 22b5d25 commit e78afea

7 files changed

Lines changed: 1 addition & 72 deletions

File tree

scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5382,13 +5382,6 @@ class facebook::react::UnimplementedViewProps : public facebook::react::HostPlat
53825382
public void setComponentName(facebook::react::ComponentName componentName);
53835383
}
53845384

5385-
class facebook::react::UnstableLegacyViewManagerAutomaticComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::LegacyViewManagerAndroidInteropShadowNode> {
5386-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
5387-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, std::string legacyComponentName);
5388-
public virtual facebook::react::ComponentHandle getComponentHandle() const override;
5389-
public virtual facebook::react::ComponentName getComponentName() const override;
5390-
}
5391-
53925385
class facebook::react::ValueAnimatedNode : public facebook::react::AnimatedNode {
53935386
protected bool isColorValue_;
53945387
public ValueAnimatedNode(facebook::react::Tag tag, const folly::dynamic& config, facebook::react::NativeAnimatedNodesManager& manager);
@@ -8216,11 +8209,6 @@ class facebook::react::BaseTextInputShadowNode : public facebook::react::Concret
82168209
public void setTextLayoutManager(std::shared_ptr<const facebook::react::TextLayoutManager> textLayoutManager);
82178210
}
82188211

8219-
template <const char* concreteComponentName>
8220-
class facebook::react::UnstableLegacyViewManagerInteropComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::ConcreteViewShadowNode<concreteComponentName, facebook::react::ViewProps>> {
8221-
public UnstableLegacyViewManagerInteropComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
8222-
}
8223-
82248212
template <facebook::react::ComponentName concreteComponentName, typename BaseShadowNodeT, typename PropsT, typename EventEmitterT = facebook::react::EventEmitter, typename StateDataT = facebook::react::StateData>
82258213
class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
82268214
protected facebook::react::Props::Shared props_;

scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5373,13 +5373,6 @@ class facebook::react::UnimplementedViewProps : public facebook::react::HostPlat
53735373
public void setComponentName(facebook::react::ComponentName componentName);
53745374
}
53755375

5376-
class facebook::react::UnstableLegacyViewManagerAutomaticComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::LegacyViewManagerAndroidInteropShadowNode> {
5377-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
5378-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, std::string legacyComponentName);
5379-
public virtual facebook::react::ComponentHandle getComponentHandle() const override;
5380-
public virtual facebook::react::ComponentName getComponentName() const override;
5381-
}
5382-
53835376
class facebook::react::ValueAnimatedNode : public facebook::react::AnimatedNode {
53845377
protected bool isColorValue_;
53855378
public ValueAnimatedNode(facebook::react::Tag tag, const folly::dynamic& config, facebook::react::NativeAnimatedNodesManager& manager);
@@ -8207,11 +8200,6 @@ class facebook::react::BaseTextInputShadowNode : public facebook::react::Concret
82078200
public void setTextLayoutManager(std::shared_ptr<const facebook::react::TextLayoutManager> textLayoutManager);
82088201
}
82098202

8210-
template <const char* concreteComponentName>
8211-
class facebook::react::UnstableLegacyViewManagerInteropComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::ConcreteViewShadowNode<concreteComponentName, facebook::react::ViewProps>> {
8212-
public UnstableLegacyViewManagerInteropComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
8213-
}
8214-
82158203
template <facebook::react::ComponentName concreteComponentName, typename BaseShadowNodeT, typename PropsT, typename EventEmitterT = facebook::react::EventEmitter, typename StateDataT = facebook::react::StateData>
82168204
class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
82178205
protected facebook::react::Props::Shared props_;

scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7964,13 +7964,6 @@ class facebook::react::UnimplementedViewProps : public facebook::react::HostPlat
79647964
public void setComponentName(facebook::react::ComponentName componentName);
79657965
}
79667966

7967-
class facebook::react::UnstableLegacyViewManagerAutomaticComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<LegacyViewManagerAndroidInteropShadowNode> {
7968-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
7969-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, std::string legacyComponentName);
7970-
public virtual facebook::react::ComponentHandle getComponentHandle() const override;
7971-
public virtual facebook::react::ComponentName getComponentName() const override;
7972-
}
7973-
79747967
class facebook::react::ValueAnimatedNode : public facebook::react::AnimatedNode {
79757968
protected bool isColorValue_;
79767969
public ValueAnimatedNode(facebook::react::Tag tag, const folly::dynamic& config, facebook::react::NativeAnimatedNodesManager& manager);
@@ -10604,11 +10597,6 @@ class facebook::react::BaseTextInputShadowNode : public facebook::react::Concret
1060410597
public void setTextLayoutManager(std::shared_ptr<const facebook::react::TextLayoutManager> textLayoutManager);
1060510598
}
1060610599

10607-
template <const char* concreteComponentName>
10608-
class facebook::react::UnstableLegacyViewManagerInteropComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::ConcreteViewShadowNode<concreteComponentName, facebook::react::ViewProps>> {
10609-
public UnstableLegacyViewManagerInteropComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
10610-
}
10611-
1061210600
template <facebook::react::ComponentName concreteComponentName, typename BaseShadowNodeT, typename PropsT, typename EventEmitterT = facebook::react::EventEmitter, typename StateDataT = facebook::react::StateData>
1061310601
class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
1061410602
protected facebook::react::Props::Shared props_;

scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7955,13 +7955,6 @@ class facebook::react::UnimplementedViewProps : public facebook::react::HostPlat
79557955
public void setComponentName(facebook::react::ComponentName componentName);
79567956
}
79577957

7958-
class facebook::react::UnstableLegacyViewManagerAutomaticComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<LegacyViewManagerAndroidInteropShadowNode> {
7959-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
7960-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, std::string legacyComponentName);
7961-
public virtual facebook::react::ComponentHandle getComponentHandle() const override;
7962-
public virtual facebook::react::ComponentName getComponentName() const override;
7963-
}
7964-
79657958
class facebook::react::ValueAnimatedNode : public facebook::react::AnimatedNode {
79667959
protected bool isColorValue_;
79677960
public ValueAnimatedNode(facebook::react::Tag tag, const folly::dynamic& config, facebook::react::NativeAnimatedNodesManager& manager);
@@ -10595,11 +10588,6 @@ class facebook::react::BaseTextInputShadowNode : public facebook::react::Concret
1059510588
public void setTextLayoutManager(std::shared_ptr<const facebook::react::TextLayoutManager> textLayoutManager);
1059610589
}
1059710590

10598-
template <const char* concreteComponentName>
10599-
class facebook::react::UnstableLegacyViewManagerInteropComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::ConcreteViewShadowNode<concreteComponentName, facebook::react::ViewProps>> {
10600-
public UnstableLegacyViewManagerInteropComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
10601-
}
10602-
1060310591
template <facebook::react::ComponentName concreteComponentName, typename BaseShadowNodeT, typename PropsT, typename EventEmitterT = facebook::react::EventEmitter, typename StateDataT = facebook::react::StateData>
1060410592
class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
1060510593
protected facebook::react::Props::Shared props_;

scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3796,13 +3796,6 @@ class facebook::react::UnimplementedViewProps : public facebook::react::HostPlat
37963796
public void setComponentName(facebook::react::ComponentName componentName);
37973797
}
37983798

3799-
class facebook::react::UnstableLegacyViewManagerAutomaticComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::LegacyViewManagerAndroidInteropShadowNode> {
3800-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
3801-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, std::string legacyComponentName);
3802-
public virtual facebook::react::ComponentHandle getComponentHandle() const override;
3803-
public virtual facebook::react::ComponentName getComponentName() const override;
3804-
}
3805-
38063799
class facebook::react::ValueAnimatedNode : public facebook::react::AnimatedNode {
38073800
protected bool isColorValue_;
38083801
public ValueAnimatedNode(facebook::react::Tag tag, const folly::dynamic& config, facebook::react::NativeAnimatedNodesManager& manager);
@@ -6254,11 +6247,6 @@ class facebook::react::BaseTextInputShadowNode : public facebook::react::Concret
62546247
public void setTextLayoutManager(std::shared_ptr<const TextLayoutManager> textLayoutManager);
62556248
}
62566249

6257-
template <const char* concreteComponentName>
6258-
class facebook::react::UnstableLegacyViewManagerInteropComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::ConcreteViewShadowNode<concreteComponentName, facebook::react::ViewProps>> {
6259-
public UnstableLegacyViewManagerInteropComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
6260-
}
6261-
62626250
template <facebook::react::ComponentName concreteComponentName, typename BaseShadowNodeT, typename PropsT, typename EventEmitterT = facebook::react::EventEmitter, typename StateDataT = facebook::react::StateData>
62636251
class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
62646252
protected facebook::react::Props::Shared props_;

scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3787,13 +3787,6 @@ class facebook::react::UnimplementedViewProps : public facebook::react::HostPlat
37873787
public void setComponentName(facebook::react::ComponentName componentName);
37883788
}
37893789

3790-
class facebook::react::UnstableLegacyViewManagerAutomaticComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::LegacyViewManagerAndroidInteropShadowNode> {
3791-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, facebook::react::RawPropsParser&& rawPropsParser = {});
3792-
public UnstableLegacyViewManagerAutomaticComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters, std::string legacyComponentName);
3793-
public virtual facebook::react::ComponentHandle getComponentHandle() const override;
3794-
public virtual facebook::react::ComponentName getComponentName() const override;
3795-
}
3796-
37973790
class facebook::react::ValueAnimatedNode : public facebook::react::AnimatedNode {
37983791
protected bool isColorValue_;
37993792
public ValueAnimatedNode(facebook::react::Tag tag, const folly::dynamic& config, facebook::react::NativeAnimatedNodesManager& manager);
@@ -6245,11 +6238,6 @@ class facebook::react::BaseTextInputShadowNode : public facebook::react::Concret
62456238
public void setTextLayoutManager(std::shared_ptr<const TextLayoutManager> textLayoutManager);
62466239
}
62476240

6248-
template <const char* concreteComponentName>
6249-
class facebook::react::UnstableLegacyViewManagerInteropComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::ConcreteViewShadowNode<concreteComponentName, facebook::react::ViewProps>> {
6250-
public UnstableLegacyViewManagerInteropComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
6251-
}
6252-
62536241
template <facebook::react::ComponentName concreteComponentName, typename BaseShadowNodeT, typename PropsT, typename EventEmitterT = facebook::react::EventEmitter, typename StateDataT = facebook::react::StateData>
62546242
class facebook::react::ConcreteShadowNode : public BaseShadowNodeT {
62556243
protected facebook::react::Props::Shared props_;

scripts/cxx-api/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ exclude_patterns:
99
exclude_symbols:
1010
- "Fantom"
1111
- "NativeReactNativeFeatureFlags"
12+
- "UnstableLegacy"
1213

1314
platforms:
1415
ReactCommon:

0 commit comments

Comments
 (0)