Skip to content

Commit e0012c0

Browse files
cipolleschireact-native-bot
authored andcommitted
Pin cmake version to 3.31.6 (#50464)
Summary: Pull Request resolved: #50464 Runners in GHA has been updated by github and they now ship with CMake 4.0. (actions/runner-images#11926) This version is not compatible with React Native, so we are pinning cmake to 3.36.1 ## Changelog: [Internal] - Pin cmake to 3.36.1 Reviewed By: cortinico Differential Revision: D72379834 fbshipit-source-id: ab09009102118e6590f02cf57fa6f9149482f62b
1 parent 2abcf99 commit e0012c0

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

.github/actions/build-hermesc-linux/action.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@ runs:
1414
shell: bash
1515
run: |
1616
sudo apt update
17-
sudo apt install -y git openssh-client cmake build-essential \
17+
sudo apt install -y git openssh-client build-essential \
1818
libreadline-dev libicu-dev jq zip python3
19+
20+
# Install cmake 3.28.3-1build7
21+
sudo apt-get install cmake=3.28.3-1build7
22+
sudo ln -sf /usr/bin/cmake /usr/local/bin/cmake
1923
- name: Restore Hermes workspace
2024
uses: ./.github/actions/restore-hermes-workspace
2125
- name: Linux cache

.github/actions/build-hermesc-windows/action.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ runs:
3939
New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\icu
4040
New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\deps
4141
New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\win64-bin
42+
- name: Downgrade CMake
43+
shell: powershell
44+
run: choco install cmake --version 3.31.6 --force
4245
- name: Build HermesC for Windows
4346
shell: powershell
4447
run: |

0 commit comments

Comments
 (0)