Fix Android Text clipping with Bold text setting (#57118)

Summary:
Fixes #54931.

Android's Bold text accessibility setting updates `Configuration.fontWeightAdjustment`, which makes platform `TextView` draw text with an adjusted typeface. React Native was measuring Text without that adjustment, so Yoga could allocate a row item width that was too small and the rendered text was clipped.

This passes the current font weight adjustment through Fabric text measurement, prepared text layout, mounted Text spans, and TextInput spans, and applies it to the `TextPaint`/`CustomStyleSpan` typeface used for measurement and drawing.

## Changelog:

[ANDROID] [FIXED] - Account for Android Bold text font weight adjustment when measuring Text.

Pull Request resolved: #57118

Test Plan:
- `./gradlew :packages:react-native:ReactAndroid:testDebugUnitTest --tests com.facebook.react.views.text.TextLayoutManagerFontWeightAdjustmentTest -Preact.internal.useHermesStable=true`
- `./gradlew :packages:react-native:ReactAndroid:ktfmtCheck -Preact.internal.useHermesStable=true`

Reproduced locally before the fix with https://github.com/Lego4m/reproducer-react-native-android-bold-text on Android 16 AVD by toggling `font_weight_adjustment` between `0` and `300`.

Screenshots from #54931:

| Bold text off | Bold text on |
| --- | --- |
| <img width="1280" height="2856" alt="Bold text off" src="https://github.com/user-attachments/assets/0e3b9be7-7935-438c-a564-084904efddc4" /> | <img width="1280" height="2856" alt="Bold text on" src="https://github.com/user-attachments/assets/9745fecc-57a1-436a-8665-0282a241dd26" /> |

Reviewed By: mdvacca

Differential Revision: D108136049

Pulled By: javache

fbshipit-source-id: 8299b94708cafebd91fdff9f6726b599a0b72445

Author: TorinAsakura

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -6079,7 +6079,9 @@ public abstract interface class com/facebook/react/views/text/ReactTextViewManag
 
 public final class com/facebook/react/views/text/ReactTypefaceUtils {
 	public static final field INSTANCE Lcom/facebook/react/views/text/ReactTypefaceUtils;
+	public static final fun applyFontWeightAdjustment (Landroid/graphics/Typeface;I)Landroid/graphics/Typeface;
 	public static final fun applyStyles (Landroid/graphics/Typeface;IILjava/lang/String;Landroid/content/res/AssetManager;)Landroid/graphics/Typeface;
+	public static final fun getFontWeightAdjustment (Landroid/content/Context;)I
 	public static final fun parseFontStyle (Ljava/lang/String;)I
 	public static final fun parseFontVariant (Lcom/facebook/react/bridge/ReadableArray;)Ljava/lang/String;
 	public static final fun parseFontWeight (Ljava/lang/String;)I

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java

@@ -93,6 +93,7 @@
 import com.facebook.react.views.text.PreparedLayout;
 import com.facebook.react.views.text.ReactTextViewManager;
 import com.facebook.react.views.text.ReactTextViewManagerCallback;
+import com.facebook.react.views.text.ReactTypefaceUtils;
 import com.facebook.react.views.text.TextEffectRegistry;
 import com.facebook.react.views.text.TextLayoutManager;
 import java.util.ArrayList;
@@ -553,6 +554,7 @@ private NativeArray measureLines(
     return (NativeArray)
         TextLayoutManager.measureLines(
             mReactApplicationContext.getAssets(),
+            ReactTypefaceUtils.getFontWeightAdjustment(mReactApplicationContext),
             attributedString,
             paragraphAttributes,
             PixelUtil.toPixelFromDIP(width),
@@ -639,6 +641,7 @@ public long measureText(
 
     return TextLayoutManager.measureText(
         mReactApplicationContext.getAssets(),
+        ReactTypefaceUtils.getFontWeightAdjustment(mReactApplicationContext),
         attributedString,
         paragraphAttributes,
         getYogaSize(minWidth, maxWidth),
@@ -666,6 +669,7 @@ public PreparedLayout prepareTextLayout(
 
     return TextLayoutManager.createPreparedLayout(
         mReactApplicationContext.getAssets(),
+        ReactTypefaceUtils.getFontWeightAdjustment(mReactApplicationContext),
         attributedString,
         paragraphAttributes,
         getYogaSize(minWidth, maxWidth),

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<00bb39539f4fc2dc0ad85a346bdee22b>>
+ * @generated SignedSource<<8b571241be0c86847ed265ab665059b2>>
  */
 
 /**
@@ -102,6 +102,12 @@ public object ReactNativeFeatureFlags {
   @JvmStatic
   public fun enableAccumulatedUpdatesInRawPropsAndroid(): Boolean = accessor.enableAccumulatedUpdatesInRawPropsAndroid()
 
+  /**
+   * When enabled, Android Text measurement and rendering respects the system Bold text accessibility setting via `Configuration.fontWeightAdjustment`.
+   */
+  @JvmStatic
+  public fun enableAndroidFontWeightAdjustment(): Boolean = accessor.enableAndroidFontWeightAdjustment()
+
   /**
    * Enables various optimizations throughout the path of measuring text on Android.
    */

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<731e92ecac8dbdf0a4b204b763a2c8c7>>
+ * @generated SignedSource<<856ed167e90b330583c3a6e981927c43>>
  */
 
 /**
@@ -32,6 +32,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
   private var disableViewPreallocationAndroidCache: Boolean? = null
   private var enableAccessibilityOrderCache: Boolean? = null
   private var enableAccumulatedUpdatesInRawPropsAndroidCache: Boolean? = null
+  private var enableAndroidFontWeightAdjustmentCache: Boolean? = null
   private var enableAndroidTextMeasurementOptimizationsCache: Boolean? = null
   private var enableBridgelessArchitectureCache: Boolean? = null
   private var enableCppPropsIteratorSetterCache: Boolean? = null
@@ -213,6 +214,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
     return cached
   }
 
+  override fun enableAndroidFontWeightAdjustment(): Boolean {
+    var cached = enableAndroidFontWeightAdjustmentCache
+    if (cached == null) {
+      cached = ReactNativeFeatureFlagsCxxInterop.enableAndroidFontWeightAdjustment()
+      enableAndroidFontWeightAdjustmentCache = cached
+    }
+    return cached
+  }
+
   override fun enableAndroidTextMeasurementOptimizations(): Boolean {
     var cached = enableAndroidTextMeasurementOptimizationsCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<4d0952ded695aec4a52b7b581ad19979>>
+ * @generated SignedSource<<2f68282c0b8c1971acdab2f229189d82>>
  */
 
 /**
@@ -52,6 +52,8 @@ public object ReactNativeFeatureFlagsCxxInterop {
 
   @DoNotStrip @JvmStatic public external fun enableAccumulatedUpdatesInRawPropsAndroid(): Boolean
 
+  @DoNotStrip @JvmStatic public external fun enableAndroidFontWeightAdjustment(): Boolean
+
   @DoNotStrip @JvmStatic public external fun enableAndroidTextMeasurementOptimizations(): Boolean
 
   @DoNotStrip @JvmStatic public external fun enableBridgelessArchitecture(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<4227353cb809dac40fe70d83154ba2bc>>
+ * @generated SignedSource<<5f946970ba2e0676b55cc150de4bee01>>
  */
 
 /**
@@ -47,6 +47,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi
 
   override fun enableAccumulatedUpdatesInRawPropsAndroid(): Boolean = false
 
+  override fun enableAndroidFontWeightAdjustment(): Boolean = true
+
   override fun enableAndroidTextMeasurementOptimizations(): Boolean = false
 
   override fun enableBridgelessArchitecture(): Boolean = false

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<156af11c13257170355284118e400435>>
+ * @generated SignedSource<<c7adeebaabd6c647865bb5398b823221>>
  */
 
 /**
@@ -36,6 +36,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
   private var disableViewPreallocationAndroidCache: Boolean? = null
   private var enableAccessibilityOrderCache: Boolean? = null
   private var enableAccumulatedUpdatesInRawPropsAndroidCache: Boolean? = null
+  private var enableAndroidFontWeightAdjustmentCache: Boolean? = null
   private var enableAndroidTextMeasurementOptimizationsCache: Boolean? = null
   private var enableBridgelessArchitectureCache: Boolean? = null
   private var enableCppPropsIteratorSetterCache: Boolean? = null
@@ -229,6 +230,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
     return cached
   }
 
+  override fun enableAndroidFontWeightAdjustment(): Boolean {
+    var cached = enableAndroidFontWeightAdjustmentCache
+    if (cached == null) {
+      cached = currentProvider.enableAndroidFontWeightAdjustment()
+      accessedFeatureFlags.add("enableAndroidFontWeightAdjustment")
+      enableAndroidFontWeightAdjustmentCache = cached
+    }
+    return cached
+  }
+
   override fun enableAndroidTextMeasurementOptimizations(): Boolean {
     var cached = enableAndroidTextMeasurementOptimizationsCache
     if (cached == null) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @generated SignedSource<<b1dd783c9075c9a35cbd06aa812e56c9>>
+ * @generated SignedSource<<c4f37ab0fc935a27bae3b92e86abc243>>
  */
 
 /**
@@ -47,6 +47,8 @@ public interface ReactNativeFeatureFlagsProvider {
 
   @DoNotStrip public fun enableAccumulatedUpdatesInRawPropsAndroid(): Boolean
 
+  @DoNotStrip public fun enableAndroidFontWeightAdjustment(): Boolean
+
   @DoNotStrip public fun enableAndroidTextMeasurementOptimizations(): Boolean
 
   @DoNotStrip public fun enableBridgelessArchitecture(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.kt

@@ -43,6 +43,7 @@ import com.facebook.react.uimanager.style.BorderRadiusProp
 import com.facebook.react.uimanager.style.BorderStyle.Companion.fromString
 import com.facebook.react.uimanager.style.LogicalEdge
 import com.facebook.react.views.text.DefaultStyleValuesUtil.getDefaultTextColorHighlight
+import com.facebook.react.views.text.ReactTypefaceUtils.getFontWeightAdjustment
 import java.util.HashMap
 
 /** View manager for `<Text>` nodes. */
@@ -158,6 +159,7 @@ public constructor(
     val spanned: Spannable =
         TextLayoutManager.getOrCreateSpannableForText(
             view.context.assets,
+            getFontWeightAdjustment(view.context),
             attributedString,
             reactTextViewManagerCallback,
             TextEffectRegistry.current,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTypefaceUtils.kt

@@ -7,14 +7,23 @@
 
 package com.facebook.react.views.text
 
+import android.content.Context
 import android.content.res.AssetManager
+import android.content.res.Configuration
 import android.graphics.Typeface
+import android.os.Build
 import com.facebook.react.bridge.ReadableArray
 import com.facebook.react.common.ReactConstants
 import com.facebook.react.common.assets.ReactFontManager
+import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
+import kotlin.math.max
+import kotlin.math.min
 
 public object ReactTypefaceUtils {
 
+  private const val FONT_WEIGHT_MIN = 1
+  private const val FONT_WEIGHT_MAX = 1000
+
   @JvmStatic
   public fun parseFontWeight(fontWeightString: String?): Int =
       when (fontWeightString) {
@@ -110,4 +119,36 @@ public object ReactTypefaceUtils {
       ReactFontManager.getInstance().getTypeface(fontFamilyName, typefaceStyle, assetManager)
     }
   }
+
+  @JvmStatic
+  public fun getFontWeightAdjustment(context: Context): Int =
+      if (
+          Build.VERSION.SDK_INT >= Build.VERSION_CODES.S &&
+              ReactNativeFeatureFlags.enableAndroidFontWeightAdjustment()
+      ) {
+        context.resources.configuration.fontWeightAdjustment
+      } else {
+        0
+      }
+
+  @JvmStatic
+  public fun applyFontWeightAdjustment(
+      typeface: Typeface?,
+      fontWeightAdjustment: Int,
+  ): Typeface? {
+    if (
+        Build.VERSION.SDK_INT < Build.VERSION_CODES.S ||
+            fontWeightAdjustment == 0 ||
+            fontWeightAdjustment == Configuration.FONT_WEIGHT_ADJUSTMENT_UNDEFINED
+    ) {
+      return typeface
+    }
+
+    val baseTypeface = typeface ?: Typeface.DEFAULT
+    val adjustedWeight =
+        min(max(baseTypeface.weight + fontWeightAdjustment, FONT_WEIGHT_MIN), FONT_WEIGHT_MAX)
+    val italic = baseTypeface.style and Typeface.ITALIC != 0
+
+    return Typeface.create(baseTypeface, adjustedWeight, italic)
+  }
 }