Commit b4876a3
Back out "Remove RCT_EXPORT_MODULE from Core modules" (#54428)
Summary:
Pull Request resolved: #54428
Backing this out because there are a couple of internal tests going in timeout when this land.
I believe that for the tests some of these modules are not registered correctly.
## Changelog:
[Internal] -
## Facebook:
See T244088155. For some reasons, these two tests:
- `buck test @//fbobjc/mode/buck2/ios-tests fbsource//fbobjc/Libraries/FBReactKit:FDSMediaWrapperServerSnapshotTests_Facebook` ([link](https://www.internalfb.com/intern/test/844425131558081))
- `buck test @//fbobjc/mode/buck2/ios-tests fbsource//fbobjc/Libraries/FBReactKit:FDSInlineReactionsServerSnapshotTests_Facebook` ([link](https://www.internalfb.com/intern/test/844425131558078))
timeouts with diff D85580258. I need to investigate which modules make these tests time out. It could be that the test setup is missing some plugin.
I'm also surprised why other FDS tests are actually passing...
Reviewed By: javache
Differential Revision: D86401358
fbshipit-source-id: b9c87fef3ab164340e2e4f108d9e6fb2c379ebc01 parent 53d8a98 commit b4876a3
62 files changed
Lines changed: 62 additions & 249 deletions
File tree
- packages/react-native
- Libraries
- Blob
- Image
- LinkingIOS
- NativeAnimation
- Network
- PushNotificationIOS
- Settings
- Text
- BaseText
- RawText
- TextInput
- Multiline
- Singleline
- Text
- VirtualText
- Vibration
- ReactCommon/react/nativemodule/samples/platform/ios/ReactCommon
- React
- CoreModules
- Modules
- Views
- RefreshControl
- SafeAreaView
- ScrollView
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
| 45 | + | |
49 | 46 | | |
50 | 47 | | |
51 | 48 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 23 | + | |
27 | 24 | | |
28 | 25 | | |
29 | 26 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 23 | + | |
27 | 24 | | |
28 | 25 | | |
29 | 26 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 23 | + | |
27 | 24 | | |
28 | 25 | | |
29 | 26 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 27 | + | |
31 | 28 | | |
32 | 29 | | |
33 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
| 95 | + | |
99 | 96 | | |
100 | 97 | | |
101 | 98 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
| 35 | + | |
39 | 36 | | |
40 | 37 | | |
41 | 38 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 23 | + | |
27 | 24 | | |
28 | 25 | | |
29 | 26 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 23 | + | |
27 | 24 | | |
28 | 25 | | |
29 | 26 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
| 30 | + | |
34 | 31 | | |
35 | 32 | | |
36 | 33 | | |
| |||
0 commit comments