Skip to content

Commit b4876a3

Browse files
cipolleschimeta-codesync[bot]
authored andcommitted
Back out "Remove RCT_EXPORT_MODULE from Core modules" (#54428)
Summary: Pull Request resolved: #54428 Backing this out because there are a couple of internal tests going in timeout when this land. I believe that for the tests some of these modules are not registered correctly. ## Changelog: [Internal] - ## Facebook: See T244088155. For some reasons, these two tests: - `buck test @//fbobjc/mode/buck2/ios-tests fbsource//fbobjc/Libraries/FBReactKit:FDSMediaWrapperServerSnapshotTests_Facebook` ([link](https://www.internalfb.com/intern/test/844425131558081)) - `buck test @//fbobjc/mode/buck2/ios-tests fbsource//fbobjc/Libraries/FBReactKit:FDSInlineReactionsServerSnapshotTests_Facebook` ([link](https://www.internalfb.com/intern/test/844425131558078)) timeouts with diff D85580258. I need to investigate which modules make these tests time out. It could be that the test setup is missing some plugin. I'm also surprised why other FDS tests are actually passing... Reviewed By: javache Differential Revision: D86401358 fbshipit-source-id: b9c87fef3ab164340e2e4f108d9e6fb2c379ebc0
1 parent 53d8a98 commit b4876a3

62 files changed

Lines changed: 62 additions & 249 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/react-native/Libraries/Blob/RCTBlobManager.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ @implementation RCTBlobManager {
4242
dispatch_queue_t _processingQueue;
4343
}
4444

45-
+ (NSString *)moduleName
46-
{
47-
return @"BlobModule";
48-
}
45+
RCT_EXPORT_MODULE(BlobModule)
4946

5047
@synthesize bridge = _bridge;
5148
@synthesize moduleRegistry = _moduleRegistry;

packages/react-native/Libraries/Blob/RCTFileReaderModule.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ @interface RCTFileReaderModule () <NativeFileReaderModuleSpec>
2020

2121
@implementation RCTFileReaderModule
2222

23-
+ (NSString *)moduleName
24-
{
25-
return @"FileReaderModule";
26-
}
23+
RCT_EXPORT_MODULE(FileReaderModule)
2724

2825
@synthesize moduleRegistry = _moduleRegistry;
2926

packages/react-native/Libraries/Image/RCTBundleAssetImageLoader.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ @interface RCTBundleAssetImageLoader () <RCTTurboModule>
2020

2121
@implementation RCTBundleAssetImageLoader
2222

23-
+ (NSString *)moduleName
24-
{
25-
return @"BundleAssetImageLoader";
26-
}
23+
RCT_EXPORT_MODULE()
2724

2825
- (BOOL)canLoadImageURL:(NSURL *)requestURL
2926
{

packages/react-native/Libraries/Image/RCTGIFImageDecoder.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ @interface RCTGIFImageDecoder () <RCTTurboModule>
2020

2121
@implementation RCTGIFImageDecoder
2222

23-
+ (NSString *)moduleName
24-
{
25-
return @"GIFImageDecoder";
26-
}
23+
RCT_EXPORT_MODULE()
2724

2825
- (BOOL)canDecodeImageData:(NSData *)imageData
2926
{

packages/react-native/Libraries/Image/RCTImageEditingManager.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ @interface RCTImageEditingManager () <NativeImageEditorSpec>
2424

2525
@implementation RCTImageEditingManager
2626

27-
+ (NSString *)moduleName
28-
{
29-
return @"ImageEditingManager";
30-
}
27+
RCT_EXPORT_MODULE()
3128

3229
@synthesize moduleRegistry = _moduleRegistry;
3330

packages/react-native/Libraries/Image/RCTImageLoader.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,7 @@ @implementation RCTImageLoader {
9292
@synthesize maxConcurrentDecodingTasks = _maxConcurrentDecodingTasks;
9393
@synthesize maxConcurrentDecodingBytes = _maxConcurrentDecodingBytes;
9494

95-
+ (NSString *)moduleName
96-
{
97-
return @"RCTImageLoader";
98-
}
95+
RCT_EXPORT_MODULE()
9996

10097
- (instancetype)init
10198
{

packages/react-native/Libraries/Image/RCTImageStoreManager.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,7 @@ @implementation RCTImageStoreManager {
3232

3333
@synthesize methodQueue = _methodQueue;
3434

35-
+ (NSString *)moduleName
36-
{
37-
return @"ImageStoreManager";
38-
}
35+
RCT_EXPORT_MODULE()
3936

4037
+ (BOOL)requiresMainQueueSetup
4138
{

packages/react-native/Libraries/Image/RCTImageViewManager.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@
2020

2121
@implementation RCTImageViewManager
2222

23-
+ (NSString *)moduleName
24-
{
25-
return @"ImageViewManager";
26-
}
23+
RCT_EXPORT_MODULE()
2724

2825
- (RCTShadowView *)shadowView
2926
{

packages/react-native/Libraries/Image/RCTLocalAssetImageLoader.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ @interface RCTLocalAssetImageLoader () <RCTTurboModule>
2020

2121
@implementation RCTLocalAssetImageLoader
2222

23-
+ (NSString *)moduleName
24-
{
25-
return @"LocalAssetImageLoader";
26-
}
23+
RCT_EXPORT_MODULE()
2724

2825
- (BOOL)canLoadImageURL:(NSURL *)requestURL
2926
{

packages/react-native/Libraries/LinkingIOS/RCTLinkingManager.mm

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,7 @@ @interface RCTLinkingManager () <NativeLinkingManagerSpec>
2727

2828
@implementation RCTLinkingManager
2929

30-
+ (NSString *)moduleName
31-
{
32-
return @"LinkingManager";
33-
}
30+
RCT_EXPORT_MODULE()
3431

3532
- (dispatch_queue_t)methodQueue
3633
{

0 commit comments

Comments
 (0)