Skip to content

Commit 60b75e4

Browse files
christophpurrerfacebook-github-bot
christophpurrer
authored and
facebook-github-bot
committed
Fix unused parameter warnings in ShadowNode.h (#56519)
Summary: Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467
1 parent 5042e58 commit 60b75e4

7 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
8383
ShadowNode(const ShadowNode &shadowNode) noexcept = delete;
8484
ShadowNode &operator=(const ShadowNode &other) noexcept = delete;
8585

86-
virtual ~ShadowNode() override = default;
86+
~ShadowNode() override = default;
8787

8888
/*
8989
* Clones the shadow node using the ShadowNode's ComponentDescriptor.
@@ -118,7 +118,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
118118
* Called, once a fully derived ShadowNode clone has been created via
119119
* ComponentDescriptor::cloneShadowNode.
120120
*/
121-
virtual void completeClone(const ShadowNode &sourceShadowNode, const ShadowNodeFragment &fragment) {}
121+
virtual void completeClone(const ShadowNode & /* sourceShadowNode */, const ShadowNodeFragment & /* fragment */) {}
122122

123123
#pragma mark - Getters
124124

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4613,14 +4613,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
46134613
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
46144614
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
46154615
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
4616-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
4616+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
46174617
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
4618-
public virtual ~ShadowNode() override = default;
46194618
public void sealRecursive() const;
46204619
public void setMounted(bool mounted) const;
46214620
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
46224621
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
46234622
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
4623+
public ~ShadowNode() override = default;
46244624
}
46254625

46264626
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -5477,7 +5477,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
54775477
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
54785478
public virtual bool getIsLayoutClean() const override;
54795479
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
5480-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
5480+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
54815481
public virtual void dirtyLayout() override;
54825482
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
54835483
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4604,14 +4604,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
46044604
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
46054605
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
46064606
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
4607-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
4607+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
46084608
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
4609-
public virtual ~ShadowNode() override = default;
46104609
public void sealRecursive() const;
46114610
public void setMounted(bool mounted) const;
46124611
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
46134612
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
46144613
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
4614+
public ~ShadowNode() override = default;
46154615
}
46164616

46174617
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -5468,7 +5468,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
54685468
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
54695469
public virtual bool getIsLayoutClean() const override;
54705470
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
5471-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
5471+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
54725472
public virtual void dirtyLayout() override;
54735473
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
54745474
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7197,14 +7197,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
71977197
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
71987198
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
71997199
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
7200-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
7200+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
72017201
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
7202-
public virtual ~ShadowNode() override = default;
72037202
public void sealRecursive() const;
72047203
public void setMounted(bool mounted) const;
72057204
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
72067205
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
72077206
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
7207+
public ~ShadowNode() override = default;
72087208
}
72097209

72107210
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {

‎scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7188,14 +7188,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
71887188
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
71897189
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
71907190
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
7191-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
7191+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
71927192
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
7193-
public virtual ~ShadowNode() override = default;
71947193
public void sealRecursive() const;
71957194
public void setMounted(bool mounted) const;
71967195
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
71977196
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
71987197
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
7198+
public ~ShadowNode() override = default;
71997199
}
72007200

72017201
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {

‎scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3173,14 +3173,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
31733173
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
31743174
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
31753175
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
3176-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
3176+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
31773177
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
3178-
public virtual ~ShadowNode() override = default;
31793178
public void sealRecursive() const;
31803179
public void setMounted(bool mounted) const;
31813180
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
31823181
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
31833182
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
3183+
public ~ShadowNode() override = default;
31843184
}
31853185

31863186
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -3892,7 +3892,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
38923892
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
38933893
public virtual bool getIsLayoutClean() const override;
38943894
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
3895-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
3895+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
38963896
public virtual void dirtyLayout() override;
38973897
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
38983898
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

‎scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3164,14 +3164,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
31643164
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
31653165
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
31663166
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
3167-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
3167+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
31683168
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
3169-
public virtual ~ShadowNode() override = default;
31703169
public void sealRecursive() const;
31713170
public void setMounted(bool mounted) const;
31723171
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
31733172
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
31743173
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
3174+
public ~ShadowNode() override = default;
31753175
}
31763176

31773177
class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
@@ -3883,7 +3883,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
38833883
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
38843884
public virtual bool getIsLayoutClean() const override;
38853885
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
3886-
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
3886+
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
38873887
public virtual void dirtyLayout() override;
38883888
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
38893889
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;

0 commit comments

Comments
 (0)