Skip to content

Commit 37b61ac

Browse files
motiz88facebook-github-bot
authored andcommitted
Drop mention of Chrome/Edge if standalone shell enabled (#53464)
Summary: Pull Request resolved: #53464 Changelog: [Internal] Minor followup from D78351937 - the Fusebox console notice still mentions that RNDT requires Chrome or Edge. Let's remove this mention for users opted into the standalone shell experiment. Reviewed By: huntie Differential Revision: D81040965 fbshipit-source-id: a290d3164261f8a1087229edfe3f69a2a9b49960
1 parent ab1af28 commit 37b61ac

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

packages/dev-middleware/src/createDevMiddleware.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ export default function createDevMiddleware({
9292
const eventReporter = createWrappedEventReporter(
9393
unstable_eventReporter,
9494
logger,
95+
experiments,
9596
);
9697

9798
const inspectorProxy = new InspectorProxy(
@@ -152,6 +153,7 @@ function getExperiments(config: ExperimentsConfig): Experiments {
152153
function createWrappedEventReporter(
153154
reporter: ?EventReporter,
154155
logger: ?Logger,
156+
experiments: Experiments,
155157
): EventReporter {
156158
return {
157159
logEvent(event: ReportableEvent) {
@@ -166,8 +168,11 @@ function createWrappedEventReporter(
166168
logger?.info(
167169
'\u001B[1m\u001B[7m💡 JavaScript logs have moved!\u001B[22m They can now be ' +
168170
'viewed in React Native DevTools. Tip: Type \u001B[1mj\u001B[22m in ' +
169-
'the terminal to open (requires Google Chrome or Microsoft Edge).' +
170-
'\u001B[27m',
171+
'the terminal to open' +
172+
(experiments.enableStandaloneFuseboxShell
173+
? ''
174+
: ' (requires Google Chrome or Microsoft Edge)') +
175+
'.\u001B[27m',
171176
);
172177
break;
173178
case 'fusebox_shell_preparation_attempt':

0 commit comments

Comments
 (0)