Skip to content

Commit 19c11ba

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Revert "Unbreak android CI by moving to ubuntu-latest (#57216)" (#57323)
Summary: This reverts the runner changes from #57216, which moved the Android CI jobs from the dedicated `4-core-ubuntu` / `8-core-ubuntu` runners onto the standard `ubuntu-latest` runners. I'm opening this (as a draft) to **see if we can speed up the RN runners** — i.e. to measure whether going back to the larger dedicated runners gives us faster CI than `ubuntu-latest`. This is an experiment to compare timings. ### What's reverted - `e2e-android-rntester.yml`: `ubuntu-latest` → `4-core-ubuntu` - `e2e-android-templateapp.yml`: `ubuntu-latest` → `4-core-ubuntu` - `fantom-tests.yml`: `ubuntu-latest` → `8-core-ubuntu` - `test-all.yml`: `build_fantom_runner`, `build_android`, `build_npm_package` → `8-core-ubuntu`; `test_android_helloworld` → `4-core-ubuntu` ### Not reverted (drift since #57216) - `nightly.yml` was deleted on main (consolidated into `publish-npm.yml`). - `publish-npm.yml` was fully restructured on main (the old `publish-react-native` reusable job no longer exists). These two are release/nightly jobs rather than the per-PR CI that determines runner speed, so they're intentionally left untouched. Changelog: [INTERNAL] - ## Changelog [INTERNAL] - Pull Request resolved: #57323 Test Plan: CI — compare job durations against `ubuntu-latest`. Reviewed By: fabriziocucci Differential Revision: D109808150 Pulled By: cortinico fbshipit-source-id: 694eba516f0d42ef733e729b23534f09dfe8548c
1 parent 9299204 commit 19c11ba

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/e2e-android-rntester.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616

1717
jobs:
1818
test:
19-
runs-on: ubuntu-latest
19+
runs-on: 4-core-ubuntu
2020
outputs:
2121
status: ${{ steps.report-status.outputs.status }}
2222
strategy:

.github/workflows/e2e-android-templateapp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616

1717
jobs:
1818
test:
19-
runs-on: ubuntu-latest
19+
runs-on: 4-core-ubuntu
2020
outputs:
2121
status: ${{ steps.report-status.outputs.status }}
2222
strategy:

.github/workflows/fantom-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616

1717
jobs:
1818
test:
19-
runs-on: ubuntu-latest
19+
runs-on: 8-core-ubuntu
2020
outputs:
2121
status: ${{ steps.report-status.outputs.status }}
2222
container:

.github/workflows/test-all.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ jobs:
218218
secrets: inherit
219219

220220
build_fantom_runner:
221-
runs-on: ubuntu-latest
221+
runs-on: 8-core-ubuntu
222222
needs: [set_release_type, check_code_changes, lint]
223223
if: needs.check_code_changes.outputs.any_code_change == 'true'
224224
container:
@@ -261,7 +261,7 @@ jobs:
261261
secrets: inherit
262262

263263
build_android:
264-
runs-on: ubuntu-latest
264+
runs-on: 8-core-ubuntu
265265
needs: [set_release_type, check_code_changes]
266266
if: |
267267
needs.check_code_changes.outputs.any_code_change == 'true' &&
@@ -307,7 +307,7 @@ jobs:
307307
secrets: inherit
308308

309309
build_npm_package:
310-
runs-on: ubuntu-latest
310+
runs-on: 8-core-ubuntu
311311
needs:
312312
[
313313
set_release_type,
@@ -340,7 +340,7 @@ jobs:
340340
skip-apple-prebuilts: ${{ needs.check_code_changes.outputs.should_test_ios == 'false' }}
341341

342342
test_android_helloworld:
343-
runs-on: ubuntu-latest
343+
runs-on: 4-core-ubuntu
344344
needs: [build_npm_package, build_android]
345345
if: ${{ always() && needs.build_android.result == 'success' && needs.build_npm_package.result == 'success' }}
346346
container:

0 commit comments

Comments
 (0)