Skip to content

Commit 100312f

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Fix unused parameter warnings in ShadowNode.h (#56519)
Summary: Pull Request resolved: #56519 Fixed clang-diagnostic-unused-parameter warnings in ShadowNode.h by commenting out unused parameter names in the completeClone method. This addresses warnings for parameters `sourceShadowNode` and `fragment` that were declared but not used in the function body. Also applied lint patch to remove redundant `virtual` keyword from the destructor declaration. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D101108467
1 parent 5c55a61 commit 100312f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

  • packages/react-native/ReactCommon/react/renderer/core

packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
8383
ShadowNode(const ShadowNode &shadowNode) noexcept = delete;
8484
ShadowNode &operator=(const ShadowNode &other) noexcept = delete;
8585

86-
virtual ~ShadowNode() override = default;
86+
~ShadowNode() override = default;
8787

8888
/*
8989
* Clones the shadow node using the ShadowNode's ComponentDescriptor.
@@ -118,7 +118,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
118118
* Called, once a fully derived ShadowNode clone has been created via
119119
* ComponentDescriptor::cloneShadowNode.
120120
*/
121-
virtual void completeClone(const ShadowNode &sourceShadowNode, const ShadowNodeFragment &fragment) {}
121+
virtual void completeClone(const ShadowNode & /* sourceShadowNode */, const ShadowNodeFragment & /* fragment */) {}
122122

123123
#pragma mark - Getters
124124

0 commit comments

Comments
 (0)