Skip to content

Commit fae33d8

Browse files
committed
🔧 textlint と日本語用ルールを導入
1 parent 71ab29b commit fae33d8

File tree

5 files changed

+1489
-2
lines changed

5 files changed

+1489
-2
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules

.textlintrc

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"rules": {
3+
"preset-japanese": true,
4+
"preset-jtf-style": {
5+
"3.1.1.全角文字と半角文字の間": false
6+
}
7+
}
8+
}

dst/CONTRIBUTING.md

+131
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,131 @@
1+
# Contributing to React Native
2+
3+
React Native is one of Facebook's first open source projects that is both under very active development and is also being used to ship code to everybody on [facebook.com](https://facebook.com). We're still working out the kinks to make contributing to this project as easy and transparent as possible, but we're not quite there yet. Hopefully this document makes the process for contributing clear and preempts some questions you may have.
4+
5+
## Our Development Process
6+
7+
Some of the core team will be working directly on GitHub. These changes will be public from the beginning. Other changesets will come via a bridge with Facebook's internal source control. This is a necessity as it allows engineers at Facebook outside of the core team to move fast and contribute from an environment they are comfortable in.
8+
9+
### `master` is unsafe
10+
11+
We will do our best to keep `master` in good shape, with tests passing at all times. But in order to move fast, we will make API changes that your application might not be compatible with. We will do our best to communicate these changes and version appropriately so you can lock into a specific version if need be.
12+
13+
### Pull Requests
14+
15+
The core team will be monitoring for pull requests. When we get one, we'll run some Facebook-specific integration tests on it first. From here, we'll need to get another person to sign off on the changes and then merge the pull request. For API changes we may need to fix internal uses, which could cause some delay. We'll do our best to provide updates and feedback throughout the process.
16+
17+
**Please submit your pull request on the `master` branch**. If the fix is critical and should be included in a stable branch please mention it and it will be cherry picked into it by a project maintainer.
18+
19+
*Before* submitting a pull request, please make sure the following is done…
20+
21+
1. Fork the repo and create your branch from `master`.
22+
2. **Describe your test plan in your commit.**
23+
- If you've added code that should be tested, add tests!
24+
- If you've changed APIs, update the documentation.
25+
- If you've updated the docs, verify the website locally and submit screenshots if applicable.
26+
27+
```
28+
$ cd website
29+
$ npm install && npm start
30+
Open the following in your browser: http://localhost:8079/react-native/index.html
31+
```
32+
33+
3. Add the copyright notice to the top of any new files you've added.
34+
4. Ensure tests pass on Travis and Circle CI.
35+
5. Make sure your code lints (`node linter.js <files touched>`).
36+
6. If you haven't already, sign the [CLA](https://code.facebook.com/cla).
37+
7. Squash your commits (`git rebase -i`).
38+
One intent alongside one commit makes it clearer for people to review and easier to understand your intention.
39+
40+
> **Note:** It is not necessary to keep clicking `Merge master to your branch` on the PR page. You would want to merge master if there are conflicts or tests are failing. The Facebook-GitHub-Bot ultimately squashes all commits to a single one before merging your PR.
41+
42+
#### Copyright Notice for files
43+
44+
Copy and paste this to the top of your new file(s):
45+
46+
```JS
47+
/**
48+
* Copyright (c) 2015-present, Facebook, Inc.
49+
* All rights reserved.
50+
*
51+
* This source code is licensed under the BSD-style license found in the
52+
* LICENSE file in the root directory of this source tree. An additional grant
53+
* of patent rights can be found in the PATENTS file in the same directory.
54+
*/
55+
```
56+
57+
If you've added a new module, add a `@providesModule <moduleName>` at the end of the comment. This will allow the haste package manager to find it.
58+
59+
### Contributor License Agreement (CLA)
60+
61+
In order to accept your pull request, we need you to submit a CLA. You only need to do this once, so if you've done this for another Facebook open source project, you're good to go. If you are submitting a pull request for the first time, just let us know that you have completed the CLA and we can cross-check with your GitHub username.
62+
63+
[Complete your CLA here](https://code.facebook.com/cla)
64+
65+
## Bugs
66+
67+
### Where to Find Known Issues
68+
69+
We are using GitHub Issues for our public bugs. We keep a close eye on this and try to make it clear when we have an internal fix in progress. Before filing a new task, try to make sure your problem doesn't already exist.
70+
71+
### Reporting New Issues
72+
73+
The best way to get your bug fixed is to provide a reduced test case. Please provide either a public repository with a runnable example or a [Sketch](https://sketch.expo.io/).
74+
75+
### Security Bugs
76+
77+
Facebook has a [bounty program](https://www.facebook.com/whitehat/) for the safe disclosure of security bugs. With that in mind, please do not file public issues; go through the process outlined on that page.
78+
79+
## How to Get in Touch
80+
81+
* [Facebook](https://www.facebook.com/groups/react.native.community/)
82+
* [Twitter](https://www.twitter.com/reactnative)
83+
84+
## Style Guide
85+
86+
### Code
87+
88+
#### General
89+
90+
* **Most important: Look around.** Match the style you see used in the rest of the project. This includes formatting, naming things in code, naming things in documentation.
91+
* Add trailing commas,
92+
* 2 spaces for indentation (no tabs)
93+
* "Attractive"
94+
95+
#### JavaScript
96+
97+
* Use semicolons;
98+
* `'use strict';`
99+
* Prefer `'` over `"`
100+
* Do not use the optional parameters of `setTimeout` and `setInterval`
101+
* 80 character line length
102+
103+
#### JSX
104+
105+
* Prefer `"` over `'` for string literal props
106+
* When wrapping opening tags over multiple lines, place one prop per line
107+
* `{}` of props should hug their values (no spaces)
108+
* Place the closing `>` of opening tags on the same line as the last prop
109+
* Place the closing `/>` of self-closing tags on their own line and left-align them with the opening `<`
110+
111+
#### Objective-C
112+
113+
* Space after `@property` declarations
114+
* Brackets on *every* `if`, on the *same* line
115+
* `- method`, `@interface`, and `@implementation` brackets on the following line
116+
* *Try* to keep it around 80 characters line length (sometimes it's just not possible...)
117+
* `*` operator goes with the variable name (e.g. `NSObject *variableName;`)
118+
119+
#### Java
120+
121+
* If a method call spans multiple lines closing bracket is on the same line as the last argument.
122+
* If a method header doesn't fit on one line each argument goes on a separate line.
123+
* 100 character line length
124+
125+
### Documentation
126+
127+
* Do not wrap lines at 80 characters - configure your editor to soft-wrap when editing documentation.
128+
129+
## License
130+
131+
By contributing to React Native, you agree that your contributions will be licensed under its BSD license.

package.json

+7-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"version": "1.0.0",
44
"description": "en-jp translations for React Native CONTRIBUTING.md",
55
"scripts": {
6-
"test": "echo \"Error: no test specified\" && exit 1"
6+
"lint": "textlint dst/CONTRIBUTING.md"
77
},
88
"repository": {
99
"type": "git",
@@ -14,5 +14,10 @@
1414
"bugs": {
1515
"url": "https://github.com/react-native-jp/CONTRIBUTING-jp/issues"
1616
},
17-
"homepage": "https://github.com/react-native-jp/CONTRIBUTING-jp#readme"
17+
"homepage": "https://github.com/react-native-jp/CONTRIBUTING-jp#readme",
18+
"devDependencies": {
19+
"textlint": "^7.4.0",
20+
"textlint-rule-preset-japanese": "^1.3.4",
21+
"textlint-rule-preset-jtf-style": "^2.2.5"
22+
}
1823
}

0 commit comments

Comments
 (0)