fix: validateFirst should not always pass (#176)

* test driven

* fix logic

Author: zombieJ

src/utils/validateUtil.ts

@@ -192,12 +192,12 @@ export function validateRules(
 
   if (validateFirst === true) {
     // >>>>> Validate by serialization
-    summaryPromise = new Promise(async resolve => {
+    summaryPromise = new Promise(async (resolve, reject) => {
       /* eslint-disable no-await-in-loop */
       for (let i = 0; i < filledRules.length; i += 1) {
         const errors = await validateRule(name, value, filledRules[i], options, messageVariables);
         if (errors.length) {
-          resolve(errors);
+          reject(errors);
           return;
         }
       }

tests/validate.test.js

@@ -383,6 +383,38 @@ describe('Form.Validate', () => {
       await timeout();
       expect(onFinish).toHaveBeenCalledWith({ switch: false });
     });
+
+    it('validateFields should not pass when validateFirst is set', async () => {
+      let form;
+
+      mount(
+        <div>
+          <Form
+            ref={instance => {
+              form = instance;
+            }}
+          >
+            <InfoField name="user" validateFirst rules={[{ required: true }]}>
+              <Input />
+            </InfoField>
+          </Form>
+        </div>,
+      );
+
+      // Validate callback
+      await new Promise(resolve => {
+        let failed = false;
+        form
+          .validateFields()
+          .catch(() => {
+            failed = true;
+          })
+          .then(() => {
+            expect(failed).toBeTruthy();
+            resolve();
+          });
+      });
+    });
   });
 
   it('should error in console if user script failed', async () => {