Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox] popover doesn't hide anymore when selecting an option with a controlled input #888

Open
tesnouf-drivy opened this issue Jan 3, 2022 · 3 comments

Comments

@tesnouf-drivy
Copy link

🐛 Bug report

Current Behavior

Selecting a popover suggestion with a controlled input (<ComboboxInput value={term} ... />) doesn't hide anymore the popover.
It used to be the case with "@reach/combobox": "0.16.3" and before (so before this commit)

Expected behavior

Selecting an option in the popover should hide it

Reproducible example

CodeSandbox Template

Software Name(s) Version
Reach Package 0.16.4
React 17.0.2
Browser Chrome 96.0.4664.110
Assistive tech
Node
npm/yarn
Operating System MacOS
@tesnouf-drivy tesnouf-drivy changed the title Combobox - popover doesn't hide anymore when selecting an option with a controlled input [Combobox] popover doesn't hide anymore when selecting an option with a controlled input Jan 3, 2022
@danielsimao
Copy link
Contributor

danielsimao commented Jan 12, 2022

This is being handled in here

@xavivars
Copy link

xavivars commented Dec 29, 2022

It seems this got fixed at some point, but then the change was reverted. Are there any plans to move forward again with a similar fix, or would it make sense to expose some sort of API in the context (similar to the close proposed here) so we can cleanly close the popover in controlled scenarios?

@wp-aberg
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants