Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dialog]: TinyMCE-React dialogs are not usable from a Reach Dialog. #785

Open
PhilMcLachlan opened this issue Apr 15, 2021 · 1 comment
Open
Labels
Help Wanted Extra attention is needed Type: Bug Something isn't working

Comments

@PhilMcLachlan
Copy link

🐛 Bug report

Current Behavior

This bug occurs when using TinyMCE-react inside a Reach Dialog, and subsequently opening a TinyMCE-react dialog. This can be seen, when using the menu item Insert | Image. The second modal dialog that pops up does not allow you to interact with the textbox controls. However, the buttons work, and the dialog can be dismissed.

Expected behavior

The TinyMCE-react Image dialog modal should allow you to type data into the textboxes. Other TinyMCE-react modals have the same problem.

Reproducible example

https://codesandbox.io/s/infallible-voice-b8zid?file=/src/index.js

Your environment

Software Name(s) Version
Reach Package "@reach/dialog" 0.10.3
React react 16.8.6
Browser Chrome 89.0.4389.128
Assistive tech
Node
npm/yarn yarn 1.22.4
Operating System MacBook Catalina
@chaance chaance added Status: Investigation Type: Bug Something isn't working labels Apr 20, 2021
@chaance chaance changed the title TinyMCE-React dialogs are not usable from a Reach Dialog. [dialog]: TinyMCE-React dialogs are not usable from a Reach Dialog. Apr 21, 2021
@chaance chaance added Help Wanted Extra attention is needed and removed Status: Investigation labels Aug 3, 2021
@behzadmehrabi
Copy link

behzadmehrabi commented Sep 17, 2021

Hi, I've been investing it and the problem is focusLock not letting you focus elements inside the second modal.

@chaance do we really need to use react-focus-lock for focus management of modal? cuz we aren't using so many of its features. what do you think about writing a custom focus lock and use that instead? and users can install/use react-focus-lock if they wanted more advanced features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants