[Tooltip] [Dialog] [Menu-Button] Tooltips get disabled forever if component is rendered conditionally

[nulladdict]

🐛 Bug report

Current Behavior

Tooltips get disabled when isOpen prop changes (or when the dialog is mounted), and get re enabled in raf.
However, if the dialog gets unmounted tooltips do not get re enabled.

Expected behavior

Tooltips get re enabled when dialog is unmounted

Reproducible example

Codesandbox link

Suggested solution(s)

I think we should enable tooltips in raf when dialog gets unmounted

Your environment

Software	Name(s)	Version
Reach Package	dialog, tooltip	0.12.1
React		latest
Browser	any	any
Assistive tech		any
Node		stable
npm/yarn		stable
Operating System	any	any

[nulladdict]

I think this lines are responsible for the behaviour, and it looks like it should be something like this instead: (upd: ignore this, this breaks tooltips inside Dialog)

React.useEffect(() => {
  if (isOpen) {
    // @ts-ignore
    window.__REACH_DISABLE_TOOLTIPS = true;
    return () => {
      window.requestAnimationFrame(() => {
        // Wait a frame so that this doesn't fire before tooltip does
        // @ts-ignore
        window.__REACH_DISABLE_TOOLTIPS = false;
      });
    };
  }
}, [isOpen]);

[nulladdict]

I've noticed there is also a problem if <Menu /> is rendered conditionally.
If menu is unmounted while being in the open state (for example MenuItem might delete the object that had the open menu) tooltips no longer work from focus.
The cause (no cleanup in the effect) and solution (adding it) are similar.

[nulladdict]

I've also noticed that tooltips nested in the Dialog no longer show up after #521, even though #390 states it shouldn’t be the case