Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast ratio for markers via default styling #670

Open
danny-andrews opened this issue Sep 17, 2020 · 1 comment
Open

Increase contrast ratio for markers via default styling #670

danny-andrews opened this issue Sep 17, 2020 · 1 comment
Labels
Status: In Progress Type: Enhancement General improvements or suggestions

Comments

@danny-andrews
Copy link
Contributor

🐛 Bug report

Current Behavior

The background color of the track and markers is #f2f2f2. This makes these elements difficult to distinguish on a white background. The contrast ratio is a measly 1.11:1!

image

Expected behavior

The track and markers should be styled to be more easily distinguishable on a white background. Playing around on https://webaim.org/resources/contrastchecker/, I came up with #D4D4D4, which gives a contrast ratio of ~1.5:1.

image

I realize the default styles are merely there to get a functional component, and are meant to be customized, but the default should at least be accessible.

@chaance
Copy link
Member

chaance commented Dec 18, 2020

I've since overhauled the slider's default styles quite a bit, but I'll double check to make sure this passes contrast checks. Thank you!

@chaance chaance added Type: Enhancement General improvements or suggestions Status: In Progress labels Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Type: Enhancement General improvements or suggestions
Projects
None yet
Development

No branches or pull requests

2 participants