Skip to content

Commit dba4b8c

Browse files
Revert to previously approved
1 parent bd385b4 commit dba4b8c

File tree

2 files changed

+17
-34
lines changed

2 files changed

+17
-34
lines changed

data-model.d.ts

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -289,17 +289,16 @@ export interface DataFactory<OutQuad extends BaseQuad = Quad, InQuad extends Bas
289289
quad(subject: InQuad['subject'], predicate: InQuad['predicate'], object: InQuad['object'], graph?: InQuad['graph']): OutQuad;
290290

291291
/**
292-
* @param original The original term.
293-
* @return A new instance of the term such that newTermInstance.equals(original) returns true.
294-
* @see Term
295-
*/
296-
fromTerm(original: InQuad): OutQuad;
297-
fromTerm<T extends Term>(original: T): T;
292+
* @param original The original term.
293+
* @return A new instance of the term such that newTermInstance.equals(original) returns true.
294+
* @see Term
295+
*/
296+
fromTerm(original: Term): Term;
298297

299298
/**
300-
* @param original The original quad.
301-
* @return A new instance of the quad such that newQuadInstance.equals(original) returns true.
302-
* @see Quad
303-
*/
299+
* @param original The original quad.
300+
* @return A new instance of the quad such that newQuadInstance.equals(original) returns true.
301+
* @see Quad
302+
*/
304303
fromQuad(original: InQuad): OutQuad;
305304
}

rdf-js-tests.ts

Lines changed: 8 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -86,24 +86,11 @@ function test_datafactory() {
8686

8787
const defaultGraph: DefaultGraph = dataFactory.defaultGraph();
8888

89-
type NamedNodeExt = NamedNode & { someProp: string };
90-
const term1: NamedNode = dataFactory.fromTerm(<NamedNodeExt>{});
91-
const term1ext: NamedNodeExt = dataFactory.fromTerm(<NamedNodeExt>{});
92-
type BlankNodeExt = BlankNode & { someProp: string };
93-
const term2: BlankNode = dataFactory.fromTerm(<BlankNodeExt>{});
94-
const term2ext: BlankNodeExt = dataFactory.fromTerm(<BlankNodeExt>{});
95-
type LiteralExt = Literal & { someProp: string };
96-
const term3: Literal = dataFactory.fromTerm(<LiteralExt>{});
97-
const term3ext: LiteralExt = dataFactory.fromTerm(<LiteralExt>{});
98-
type VariableExt = Variable & { someProp: string };
99-
const term4: Variable = dataFactory.fromTerm(<VariableExt> {});
100-
const term4ext: VariableExt = dataFactory.fromTerm(<VariableExt> {});
101-
type DefaultGraphExt = DefaultGraph & { someProp: string };
102-
const term5: DefaultGraph = dataFactory.fromTerm(<DefaultGraphExt>{});
103-
const term5ext: DefaultGraphExt = dataFactory.fromTerm(<DefaultGraphExt>{});
104-
type OutQuadExt = Quad & { someProp: string };
105-
const term6: Quad = dataFactory.fromTerm(<OutQuadExt>{});
106-
const term6ext: OutQuadExt = dataFactory.fromTerm<OutQuadExt>(<OutQuadExt>{});
89+
const term1: Term = dataFactory.fromTerm(dataFactory.namedNode(""));
90+
const term2: Term = dataFactory.fromTerm(dataFactory.blankNode());
91+
const term3: Term = dataFactory.fromTerm(dataFactory.literal(""));
92+
const term4: Term = dataFactory.fromTerm(dataFactory.variable ? dataFactory.variable("v1") : <any> {});
93+
const term5: Term = dataFactory.fromTerm(dataFactory.defaultGraph());
10794

10895
const quadFromQuad: Term = dataFactory.fromQuad(dataFactory.quad(
10996
dataFactory.namedNode("x"),
@@ -148,7 +135,7 @@ function test_datafactory_star() {
148135
const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else'));
149136
}
150137

151-
const quadTerm: Quad = dataFactory.fromTerm(quadBobAge);
138+
const quadTerm: Term = dataFactory.fromTerm(quadBobAge);
152139
}
153140

154141
function test_datafactory_star_basequad() {
@@ -176,9 +163,7 @@ function test_datafactory_star_basequad() {
176163

177164
const datafactoryBaseQuadToQuad: DataFactory<BaseQuad, Quad> = <any> {};
178165

179-
const quadToBaseQuad1: BaseQuad = datafactoryBaseQuadToQuad.fromTerm(quadBobAge);
180-
181-
const baseQuadTerm: BaseQuad = dataFactory.fromTerm(quadBobAge);
166+
const baseQuadTerm: Term = dataFactory.fromTerm(quadBobAge);
182167

183168
const baseQuad: BaseQuad = dataFactory.fromQuad(quadBobAge);
184169

@@ -191,8 +176,7 @@ function test_datafactory_star_basequad() {
191176
dataFactory.literal('23'),
192177
);
193178

194-
const quadTerm: Quad = quadDataFactory.fromTerm(regularQuadBobAge);
195-
const quadTerm2: Quad = datafactoryBaseQuadToQuad.fromTerm<Quad>(regularQuadBobAge);
179+
const quadTerm: Term = quadDataFactory.fromTerm(regularQuadBobAge);
196180
}
197181

198182
function test_stream() {

0 commit comments

Comments
 (0)