Skip to content
This repository was archived by the owner on Jul 3, 2025. It is now read-only.

Commit 2bb1c48

Browse files
authored
chore: modernize tests according to staticheck hints (#28)
No functional change.
1 parent 206b625 commit 2bb1c48

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

resolver_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,12 +310,13 @@ func TestResolver_LookupHost(t *testing.T) {
310310
mockQuery: func(ctx context.Context, addr *ServerAddr, query *dns.Msg) (*dns.Msg, error) {
311311
msg := &dns.Msg{}
312312
msg.SetReply(query)
313-
if query.Question[0].Qtype == dns.TypeA {
313+
switch query.Question[0].Qtype {
314+
case dns.TypeA:
314315
msg.Answer = append(msg.Answer, &dns.A{
315316
Hdr: dns.RR_Header{Name: query.Question[0].Name, Rrtype: dns.TypeA, Class: dns.ClassINET, Ttl: 300},
316317
A: net.ParseIP("192.0.2.1"),
317318
})
318-
} else if query.Question[0].Qtype == dns.TypeAAAA {
319+
case dns.TypeAAAA:
319320
msg.Answer = append(msg.Answer, &dns.AAAA{
320321
Hdr: dns.RR_Header{Name: query.Question[0].Name, Rrtype: dns.TypeAAAA, Class: dns.ClassINET, Ttl: 300},
321322
AAAA: net.ParseIP("2001:db8::1"),

response_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,12 @@ func TestRCodeToError(t *testing.T) {
140140
resp := new(dns.Msg)
141141
resp.Rcode = tt.rcode
142142

143-
if tt.name == "LameReferral" {
143+
switch tt.name {
144+
case "LameReferral":
144145
resp.Authoritative = false
145146
resp.RecursionAvailable = false
146147
resp.Answer = nil
147-
} else if tt.name == "Success" {
148+
case "Success":
148149
resp.Authoritative = true
149150
resp.RecursionAvailable = true
150151
resp.Answer = []dns.RR{&dns.A{

0 commit comments

Comments
 (0)