From c238b6eafef66add2529928294b50f14f5d380da Mon Sep 17 00:00:00 2001 From: Ravi Suhag Date: Sat, 2 Nov 2024 19:12:23 +0530 Subject: [PATCH] fix: resolve release info bug --- version/release.go | 2 +- version/release_test.go | 20 -------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/version/release.go b/version/release.go index 8897b5d..f6edbb9 100644 --- a/version/release.go +++ b/version/release.go @@ -54,7 +54,7 @@ func ReleaseInfo(releaseURL string) (*Info, error) { } }() if resp.StatusCode != http.StatusOK { - return nil, errors.Wrapf(err, "failed to reach releaseURL: %s, status code: %d", releaseURL, resp.StatusCode) + return nil, fmt.Errorf("failed to reach releaseURL: %s, status code: %d", releaseURL, resp.StatusCode) } body, err := io.ReadAll(resp.Body) diff --git a/version/release_test.go b/version/release_test.go index cc50c09..fa291cf 100644 --- a/version/release_test.go +++ b/version/release_test.go @@ -77,26 +77,6 @@ func TestIsCurrentLatest(t *testing.T) { } } -func TestUpdateNotice(t *testing.T) { - // Mock a successful GitHub API response with a newer version - mockResponse := `{ - "tag_name": "v2.0.0", - "tarball_url": "https://example.com/tarball/v2.0.0" - }` - server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - w.WriteHeader(http.StatusOK) - w.Write([]byte(mockResponse)) - })) - defer server.Close() - - notice := UpdateNotice("1.0.0", server.URL) - assert.Equal(t, "A new release (v2.0.0) is available, consider updating the client.", notice) - - // Test with the current version being the latest - notice = UpdateNotice("2.0.0", server.URL) - assert.Equal(t, "", notice) -} - func TestUpdateNotice_ErrorHandling(t *testing.T) { // Mock a server that returns an error server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {