Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Replace :object_manager with smaller Bazel targets. #51014

Open
kevin85421 opened this issue Mar 1, 2025 · 0 comments
Open

[CI] Replace :object_manager with smaller Bazel targets. #51014

kevin85421 opened this issue Mar 1, 2025 · 0 comments
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray help-wanted

Comments

@kevin85421
Copy link
Member

kevin85421 commented Mar 1, 2025

Description

#50885 splits :object_manager into smaller targets. Therefore, we can also replace :object_manager with smaller targets as dependencies. For example, pull_manager_test.cc only requires "ray/object_manager/pull_manager.h", so we don't need to use the entire object_manager.

ray_cc_test(
    name = "pull_manager_test",
    size = "small",
    srcs = [
        "src/ray/object_manager/test/pull_manager_test.cc",
    ],
    tags = ["team:core"],
    deps = [
        ":object_manager",
        "@com_google_googletest//:gtest_main",
    ],
)

Part of #50586

Use case

No response

@kevin85421 kevin85421 added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) good-first-issue Great starter issue for someone just starting to contribute to Ray and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 1, 2025
@dentiny dentiny added core Issues that should be addressed in Ray Core help-wanted labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability good-first-issue Great starter issue for someone just starting to contribute to Ray help-wanted
Projects
None yet
Development

No branches or pull requests

2 participants