Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Add tests to make sure backend change won't break frontend #47751

Open
jjyao opened this issue Sep 19, 2024 · 1 comment
Open

[Dashboard] Add tests to make sure backend change won't break frontend #47751

jjyao opened this issue Sep 19, 2024 · 1 comment
Labels
dashboard Issues specific to the Ray Dashboard enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@jjyao
Copy link
Collaborator

jjyao commented Sep 19, 2024

What happened + What you expected to happen

Recently we made some backend change that breaks the frontend but it's not caught by our tests: #47714. This reveals that we lack test coverage. This issue tracks the things we need to do to prevent this from happening in the future:

  1. Add pydantic model for every API
  2. Make sure every API is tested by unit tests
  3. Generate client model request code from pydantic model

Versions / Dependencies

master

Reproduction script

N/A

Issue Severity

None

@jjyao jjyao added bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Sep 19, 2024
@jjyao
Copy link
Collaborator Author

jjyao commented Sep 19, 2024

cc @alanwguo

@jjyao jjyao added enhancement Request for new feature and/or capability and removed bug Something that is supposed to be working; but isn't labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Issues specific to the Ray Dashboard enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

1 participant