Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[adag] Ray ADAG tests (test_accelerated_dag) do not have sufficient coverage for async cases #47662

Open
jeffreyjeffreywang opened this issue Sep 13, 2024 · 0 comments
Open

[adag] Ray ADAG tests (test_accelerated_dag) do not have sufficient coverage for async cases #47662

jeffreyjeffreywang opened this issue Sep 13, 2024 · 0 comments
Labels
accelerated-dag bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@jeffreyjeffreywang
Copy link
Contributor

What happened + What you expected to happen

Compared to the synchronous execute API, the async APIs for ADAG don't have sufficient test coverage. Most tests in test_accelerated_dag are performed on synchronous APIs but not on asynchronous ones. We can get around this issue if sync and async codepath are unified per #46307.

This has low priority. Merely an improvement to make our tests more robust and thorough for async ADAG APIs.

Versions / Dependencies

ray master

Reproduction script

N/A

Issue Severity

Low: It annoys or frustrates me.
@jeffreyjeffreywang jeffreyjeffreywang added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Sep 13, 2024
@jeffreyjeffreywang jeffreyjeffreywang changed the title [adag] Ray ADAG tests (test_accelerated_dag) does not have sufficient coverage for async cases [adag] Ray ADAG tests (test_accelerated_dag) do not have sufficient coverage for async cases Sep 13, 2024
@jeffreyjeffreywang jeffreyjeffreywang mentioned this issue Sep 13, 2024
Merged
8 tasks
@anyscalesam anyscalesam added accelerated-dag core Issues that should be addressed in Ray Core labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accelerated-dag bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffreyjeffreywang @anyscalesam