Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aDAG] Add documentation for actor.method.bind(args), especially when args is a list #47661

Open
ruisearch42 opened this issue Sep 13, 2024 · 0 comments
Labels
accelerated-dag docs An issue or change related to documentation P2 Important issue, but not time-critical triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@ruisearch42
Copy link
Contributor

ruisearch42 commented Sep 13, 2024

Description

When creating an aDAG, suppose we have activations which is a list of DAGNode, if we'd like to bind them in an actor method reduce_activations, we should use:

actor.reduce_activations.bind(*activations)

instead of

actor.reduce_activations.bind(activations)

Otherwise an exception is thrown:

ValueError: Compiled DAGs require each task to take a ray.dag.InputNode or at least one other DAGNode as an input

This should be explicitly mentioned in the docs when we have beta release.

Link

No response

@ruisearch42 ruisearch42 added triage Needs triage (eg: priority, bug/not-bug, and owning component) docs An issue or change related to documentation labels Sep 13, 2024
@ruisearch42 ruisearch42 added the P2 Important issue, but not time-critical label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerated-dag docs An issue or change related to documentation P2 Important issue, but not time-critical triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

2 participants