Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow referring requirements.txt path from zipfile in runtime_env in serveConfigV2 #2351

Open
1 of 2 tasks
hanish-sx opened this issue Sep 3, 2024 · 0 comments
Open
1 of 2 tasks
Labels
core enhancement New feature or request triage

Comments

@hanish-sx
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Allow users to refer the requirements.txt file in runtime_env from the zipfile provided as working_dir.

Use case

Allowing users to refer the requirements.txt file in runtime_env from the zipfile provided as working_dir, will be convenient to package the app with their requirements rather than having to enumerate each dependency in the pip section. Having to enumerate each dependency one by one can get unwieldy.

I like to use the compiled requirements created by using pip-tools to pin each dependency. So having that in a file would be convenient as well as keep the yaml file short.

apiVersion: ray.io/v1alpha1
kind: RayService
metadata:
  name: rayservice-sample
spec:
  serveConfigV2: |
    applications:
      - name: text_ml_app
        import_path: text_ml.app
        route_prefix: /summarize_translate
        runtime_env:
          working_dir: "s3://bucket/path/app.zip"
          pip:
            - "./requirements.txt" # This will be from the app.zip

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@hanish-sx hanish-sx added enhancement New feature or request triage labels Sep 3, 2024
@rkooo567 rkooo567 added the core label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants