diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index c37afc617..cb029d57a 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -150,11 +150,12 @@ if(RMM_NVTX) target_compile_definitions(rmm PUBLIC RMM_NVTX) endif() -set(RMM_CXX_FLAGS -Wall -Werror -Wextra -Wsign-conversion -Wno-unknown-pragmas - -Wno-error=deprecated-declarations) +set(RMM_CXX_FLAGS -Wall -Werror -Wextra -Wnon-virtual-dtor -Woverloaded-virtual -Wsign-conversion + -Wno-unknown-pragmas -Wno-error=deprecated-declarations) set(RMM_CUDA_FLAGS -Werror=all-warnings - -Xcompiler=-Wall,-Werror,-Wextra,-Wsign-conversion,-Wno-error=deprecated-declarations) + -Xcompiler=-Wall,-Werror,-Wextra,-Wnon-virtual-dtor,-Woverloaded-virtual,-Wsign-conversion,-Wno-error=deprecated-declarations +) target_compile_options(rmm PRIVATE "$<$:${RMM_CXX_FLAGS}>" "$<$:${RMM_CUDA_FLAGS}>") diff --git a/cpp/benchmarks/CMakeLists.txt b/cpp/benchmarks/CMakeLists.txt index 85948ac18..95a841d53 100644 --- a/cpp/benchmarks/CMakeLists.txt +++ b/cpp/benchmarks/CMakeLists.txt @@ -9,9 +9,11 @@ option(DISABLE_DEPRECATION_WARNING "Disable warnings generated from deprecated declarations." OFF) option(PER_THREAD_DEFAULT_STREAM "Build with per-thread default stream" OFF) -set(RMM_BENCHMARKS_CXX_FLAGS -Wall -Werror -Wextra -Wsign-conversion -Wno-unknown-pragmas) -set(RMM_BENCHMARKS_CUDA_FLAGS -Werror=all-warnings - -Xcompiler=-Wall,-Werror,-Wextra,-Wsign-conversion) +set(RMM_BENCHMARKS_CXX_FLAGS -Wall -Werror -Wextra -Wnon-virtual-dtor -Woverloaded-virtual + -Wsign-conversion -Wno-unknown-pragmas) +set(RMM_BENCHMARKS_CUDA_FLAGS + -Werror=all-warnings + -Xcompiler=-Wall,-Werror,-Wextra,-Wnon-virtual-dtor,-Woverloaded-virtual,-Wsign-conversion) if(PER_THREAD_DEFAULT_STREAM) message(STATUS "RMM: Building benchmarks with per-thread default stream") diff --git a/cpp/tests/CMakeLists.txt b/cpp/tests/CMakeLists.txt index 88744fe15..d03534fcf 100644 --- a/cpp/tests/CMakeLists.txt +++ b/cpp/tests/CMakeLists.txt @@ -9,8 +9,11 @@ option(DISABLE_DEPRECATION_WARNING "Disable warnings generated from deprecated declarations." OFF) option(CODE_COVERAGE "Enable generating code coverage with gcov." OFF) -set(RMM_TESTS_CXX_FLAGS -Wall -Werror -Wextra -Wsign-conversion -Wno-unknown-pragmas) -set(RMM_TESTS_CUDA_FLAGS -Werror=all-warnings -Xcompiler=-Wall,-Werror,-Wextra,-Wsign-conversion) +set(RMM_TESTS_CXX_FLAGS -Wall -Werror -Wextra -Wnon-virtual-dtor -Woverloaded-virtual + -Wsign-conversion -Wno-unknown-pragmas) +set(RMM_TESTS_CUDA_FLAGS + -Werror=all-warnings + -Xcompiler=-Wall,-Werror,-Wextra,-Wnon-virtual-dtor,-Woverloaded-virtual,-Wsign-conversion) include(rapids-test) rapids_test_init()