Upgrade nanoarrow #20711
Merged
Upgrade nanoarrow #20711
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
| NANOARROW_THROW_NOT_OK(ArrowSchemaSetTypeDecimal(expected_schema->children[0], | ||
| NANOARROW_TYPE_DECIMAL64, | ||
| cudf::detail::max_precision<int64_t>(), | ||
| cudf::detail::max_precision<int64_t>() - 1, |
Contributor
There was a problem hiding this comment.
Is -1 needed because we want to pass a valid max value of 18 for NANOARROW_TYPE_DECIMAL64?
Contributor
There was a problem hiding this comment.
Is this to fix an existing bug or due to breaking change in the new nanoarrow version?
Contributor
Author
There was a problem hiding this comment.
This was a preexisting bug in our test that was caught by newer validation in nanoarrow added in https://github.com/apache/arrow-nanoarrow/pull/717/files#diff-c970ca53f60f17860a9b1ca7b58e52276ac1c047c39d54b8d99a240f9a17c357.
kingcrimsontianyu
approved these changes
Nov 24, 2025
Contributor
kingcrimsontianyu
left a comment
kingcrimsontianyu
left a comment
There was a problem hiding this comment.
Looks good. Just a small question on test.
ttnghia
approved these changes
Nov 27, 2025
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves us to a release of nanoarrow instead of using an intermediate dev tag. I ran into some issues with the upgrade in #20669 so I've split out those changes for testing here.
Checklist