Fix CompletionDock activity twitch from ACP reports - #1906
Merged
simple-agent-manager[bot] merged 8 commits intoAug 25, 2026
Merged
Fix CompletionDock activity twitch from ACP reports#1906simple-agent-manager[bot] merged 8 commits into
simple-agent-manager[bot] merged 8 commits into
Conversation
Contributor
|
simple-agent-manager
Bot
deleted the
sam/fix-twitchy-completiondock-stoppause-stnnev
branch
August 25, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Agent Preflight
Classifications
External References
N/A: This change is contained within SAM repo behavior and documentation; no external APIs or third-party contracts changed.
Codebase Impact Analysis
Documentation & Specs
Updated .claude/rules/06-vm-agent-patterns.md, .claude/skills/env-reference/SKILL.md, apps/www/src/content/docs/docs/reference/configuration.md, and apps/www/src/content/docs/docs/reference/vm-agent.md for ACP_HARNESS_ACTIVITY_REPORT_DEBOUNCE.
Constitution & Risk Check
Checked Principle XI / no hardcoded values: debounce delay is configurable via ACP_HARNESS_ACTIVITY_REPORT_DEBOUNCE and defaults are centralized in VM-agent config. The UI stabilization scope was limited to the working prop, avoiding CompletionDock visual design or animation changes.
Summary
ACP_HARNESS_ACTIVITY_REPORT_DEBOUNCEsetting and VM-agent callback guidanceValidation
pnpm typecheckpnpm lint(existing warnings only)pnpm testpnpm buildPATH="/workspaces/simple-agent-manager/.tmp/go-toolchain/go/bin:$PATH" go test ./...frompackages/vm-agentPATH="/workspaces/simple-agent-manager/.tmp/go-toolchain/go/bin:$PATH" go vet ./internal/acp ./internal/configfrompackages/vm-agentPATH="/workspaces/simple-agent-manager/.tmp/go-toolchain/go/bin:$PATH" go test -race ./internal/acp ./internal/configfrompackages/vm-agentpnpm --filter @simple-agent-manager/web test -- tests/unit/components/useCompletionDockWorking.test.tspnpm --filter @simple-agent-manager/web exec playwright test tests/playwright/completion-dock-audit.spec.ts --project "iPhone SE (375x667)" --project "Desktop (1280x800)" --reporter=linepnpm --filter @simple-agent-manager/www buildPATH="/workspaces/simple-agent-manager/.tmp/go-toolchain/go/bin:$PATH" go test ./internal/acpfrompackages/vm-agentafter replacing token-shaped fixturespnpm quality:gitleaks:currentpnpm quality:gitleaks:prStaging
32838455761passed deploy and GitHub smoke-tests jobs01M0W9A19ZKHNRTED6QKGGBYW1used fresh node01M0W9A6P4GC57Z33PBN6SZYE7and workspace01M0W9KMAKSADEY31MM4BG8XN6a7b661f70f619d613b22bc6f32fca51b05aeb261activity=prompting,runtimeWorkState=active,runtimeWorkCount=1, and the live UI exposedInterrupt agentactivity=idle,runtimeWorkState=inactive,runtimeWorkCount=0, and the live UI stabilized toSleep session/api/nodesand/api/workspacesto[]