-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] Disable boot entry if efivars is read-only (#2059) #2145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 in general
But I'm missing a test case.
Right! Adding one here #2148, gonna include it in this PR once merged |
On some systems the efivars is mounted read-only if the firmware does not support writing (such as RPI). This commit turns off writing boot entries to efivars if the efivars filesystem is mounted read-only. Signed-off-by: Fredrik Lönnegren <[email protected]> (cherry picked from commit 8baaef2)
Signed-off-by: David Cassany <[email protected]> (cherry picked from commit 76caad5)
9c20918
to
c6fd7ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good here!
On some systems the efivars is mounted read-only if the firmware does not support writing (such as RPI).
This commit turns off writing boot entries to efivars if the efivars filesystem is mounted read-only.
Signed-off-by: Fredrik Lönnegren [email protected]
(cherry picked from commit 8baaef2)
Fixes #2116