Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Disable boot entry if efivars is read-only (#2059) #2145

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Jul 18, 2024

On some systems the efivars is mounted read-only if the firmware does not support writing (such as RPI).

This commit turns off writing boot entries to efivars if the efivars filesystem is mounted read-only.

Signed-off-by: Fredrik Lönnegren [email protected]
(cherry picked from commit 8baaef2)

Fixes #2116

@davidcassany davidcassany requested a review from a team as a code owner July 18, 2024 10:04
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 in general
But I'm missing a test case.

@davidcassany
Copy link
Contributor Author

davidcassany commented Jul 18, 2024

👍 in general But I'm missing a test case.

Right! Adding one here #2148, gonna include it in this PR once merged

@davidcassany davidcassany added the status/blocked Issue depends on another one label Jul 18, 2024
@davidcassany
Copy link
Contributor Author

Blocked as it requires #2146 and a backport of #2148

@davidcassany davidcassany changed the title Disable boot entry if efivars is read-only (#2059) [backport] Disable boot entry if efivars is read-only (#2059) Jul 18, 2024
@davidcassany davidcassany self-assigned this Jul 18, 2024
frelon and others added 2 commits July 29, 2024 06:54
On some systems the efivars is mounted read-only if the firmware does
not support writing (such as RPI).

This commit turns off writing boot entries to efivars if the efivars
filesystem is mounted read-only.

Signed-off-by: Fredrik Lönnegren <[email protected]>
(cherry picked from commit 8baaef2)
Signed-off-by: David Cassany <[email protected]>
(cherry picked from commit 76caad5)
@davidcassany davidcassany removed the status/blocked Issue depends on another one label Jul 29, 2024
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here!

@davidcassany davidcassany merged commit 38f4d14 into rancher:v2.1.x Jul 29, 2024
17 checks passed
@davidcassany davidcassany deleted the v2.1.x_backport branch July 29, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Elemental on Raspberry Pi Fails OEM/Persistence Reset due to Empty /oem Directory
4 participants