You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am wondering if shouldn't we just make a best effort call, if the command is not there only log it can't be executed but do nothing and do not return error. If it is there then normally execute it. We could even consider swallowing any error and just log it. If the target device is managed by lvm somehow it will also fail in later steps in any case.
With this change we could consider dropping lvm requirement from elemental package.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
I am wondering if we could remove the LVM stack requirement from elemental.
We only need due to this code
elemental-toolkit/pkg/elemental/elemental.go
Lines 657 to 666 in 3ea9d75
blkdeactivate
is provided by the LVM package.Describe the solution you'd like
I am wondering if shouldn't we just make a best effort call, if the command is not there only log it can't be executed but do nothing and do not return error. If it is there then normally execute it. We could even consider swallowing any error and just log it. If the target device is managed by lvm somehow it will also fail in later steps in any case.
With this change we could consider dropping lvm requirement from elemental package.
The text was updated successfully, but these errors were encountered: