Repository navigation
Conversation
Add macos-cursor-shake-to-find mod
|
Thanks for the pull request! This repository uses a two-stage review: an AI review that you run yourself, followed by a human review. To get started, comment See the pull request review process for the full details. |
Add macos-cursor-shake-to-find.wh.cpp
Update macos-cursor-shake-to-find.wh.cpp now is using a version without having to use external files. now it has much more functions, i hope you guys like it
Update macos-cursor-shake-to-find.wh.cpp
|
/ready-for-reviewer |
|
@brcarvp See the pull request review process for details. |
|
/ai-review |
Submission reviewNote: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. The mod mostly works as described, but the items below need changes before it can be merged. 1. Shaking the mouse makes the pointer disappear when the macOS theme isn't applied. The overlay bitmap
Fix: create the 256 px overlay bitmap independently of the cursor theme, e.g. once at the start of the worker thread (and again after a settings change, on that thread), not in 2. This should be a tool mod, not code running inside
Fix: move the theme and Shake to Find code to a tool mod: 3. Large overlap with existing mods. Every feature here already exists in the catalog:
The PR doesn't say why this should be a separate mod (the body is only the template). The maintainer prefers extending existing mods over adding near-duplicates. The path for that is an issue or PR to the authors of 4. The worker thread has a visible window but no message loop, and it polls at 60 Hz forever.
Fix: make the thread event-driven with a real message loop:
5. 6. The generated 7. "Keep Cursor Visible While Typing" silently overrides a Windows setting, and it's on by default.
Please default it to 8. Add a screenshot or GIF to the README. This is a purely visual mod, so users need to see the cursor set and the shake effect before installing. Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations and ideas about the feature behavior itself.
Code overview
For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit Code regions
Side effects of interest
Next steps:
See the review process for details. Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)". |
Update macos-cursor-shake-to-find.wh.cpp
|
/ai-review |
Submission reviewNote: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. Thanks for the update. These earlier items are resolved:
Three items still need changes: 1. Large overlap with existing mods (not addressed yet). Every feature here already exists in the catalog:
The PR still doesn't say why this should be a separate mod: the body is only the template, and there's no comment about it. The maintainer prefers extending existing mods over adding near-duplicates. The path for that is an issue or PR to the authors of 2. The worker thread still polls about 60 times a second, forever. The message pump fixed the hung-window problem. But Now that the thread has a message loop, both inputs can be event-driven:
3. The generated Use Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations and ideas about the feature behavior itself.
Code overview
For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit Code regions
Side effects of interest
Next steps:
See the review process for details. Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)". |
|
The main reason this is submitted as a standalone suite rather than extending mouse-cursor-themes or shake-to-find-cursor is that it bridges a highly specific gap: it provides a procedural vector-based macOS shape generator that dynamically scales to 4K without bitmap pixelation, and combines it natively with an intelligent 'Shake to Find' feature that intercepts and magnifies the actual underlying Windows cursors in excluded apps (like Word). |
Update macos-cursor-shake-to-find.wh.cpp
Update macos-cursor-shake-to-find.wh.cpp
|
/ai-review |
Add macos-cursor-shake-to-find mod
Changelog
If this pull request updates an existing mod, describe the changes inside the changelog markers:
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.