Repository navigation
Add mod: Windows 11 Lock Screen Styler - #6413
ZACHARIAgs wants to merge 5 commits into
Conversation
Based off of Start Menu Styler: Lock Screen Styler!
|
Thanks for the pull request! This repository uses a two-stage review: an AI review that you run yourself, followed by a human review. To get started, comment See the pull request review process for the full details. |
|
/ai-review |
Submission reviewNote: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. The styling engine is a near-verbatim copy of the Start Menu Styler's, with one addition: a 1. Custom styles are silently dropped, and leftover migration code causes bugs (lines 7030–7071, 7602, 7014–7028, 7223–7259, 7341–7342)
This and the other "legacy" handling exist to migrate from versions 1.4 and earlier, which were never published in the catalog. Nobody has those settings, so please remove all of it:
2. The dedicated settings can't be turned off, and they override custom styles (lines 7216–7547, 7625–7633)
Suggested fix:
3. Global XAML state is released by automatic destructors when LockApp exits (lines 1128, 1196–1197, 1376–1380, 1471–1472)
This code is inherited unchanged from the Start Menu Styler engine (none of the stylers use 4. The default font isn't part of Windows The clock and date both default to 5. Single author
6. Add a screenshot This is a purely visual mod, and the README has no image. Please add a screenshot of each theme (hosted on Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations and ideas about the feature behavior itself.
Code overview
For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit Code regions
Side effects of interest
Next steps:
See the review process for details. Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)". |
|
/ai-review |
Submission reviewNote: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. Most of the first round is fixed:
Two items remain. 1. The attribute is now on every container as a bare attribute, and the cleanup was changed from
2. The I missed this in the previous round. The Fix:
This is inherited unchanged from the Start Menu Styler engine. The maintainer may prefer to fix it in the shared engine. Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations and ideas about the feature behavior itself.
Code overview
For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit Code regions
Side effects of interest
Next steps:
See the review process for details. Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)". |
|
/ai-review |
Submission reviewNote: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. Both items from the previous round are mostly addressed:
One ordering problem remains in that wait. 1. Wait for the advise threads before unadvising, not after (lines 7543–7580)
The wait only makes sure the thread itself has left the DLL. Once the DLL is unloaded, the next visual tree change calls into unmapped code and crashes LockApp.
Fix: wait at the start of both callbacks, on the engine thread, before void WaitForAdviseThreads() {
std::vector<HANDLE> threads;
{
std::lock_guard<std::mutex> lock(g_adviseThreadsMutex);
threads.swap(g_adviseThreads);
}
for (HANDLE thread : threads) {
WaitForSingleObject(thread, INFINITE);
CloseHandle(thread);
}
}
void Wh_ModUninit() {
Wh_Log(L">");
StopImageLoadRetries();
WaitForAdviseThreads(); // Before the watcher is unadvised.
HWND hCoreWnd = GetCoreWnd();
...
}
void Wh_ModSettingsChanged() {
Wh_Log(L">");
WaitForAdviseThreads();
HWND hCoreWnd = GetCoreWnd();
...
}Optional improvements
Minor polish — none of this affects users, so it's your call.
Functionality notes
Non-critical observations and ideas about the feature behavior itself.
Code overview
For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit
Code regions
Side effects of interest
Next steps:
See the review process for details. Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)". |
|
/ai-review |
|
This pull request has already had 3 AI reviews in the last 24 hours, which is the limit, so no review was posted this time. Comment |
|
/ai-review |
|
This pull request has already had 3 AI reviews in the last 24 hours, which is the limit, so no review was posted this time. Comment |
|
/ai-review |
Submission reviewNote: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding. Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it. Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them. No blocking issues — looks good to merge. Everything from the previous round is addressed:
Functionality notes
Non-critical observations and ideas about the feature behavior itself.
Code overview
For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit
Code regions
Side effects of interest
Next steps:
See the review process for details. Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)". |
|
/ready-for-reviewer |
|
Thank you for the submission. Currently, I'm the maintainer of all five XAML styler mods, and many of the fixes and improvements are applied to all of them (e.g. In addition, I could create a styling guide For Settings similar to the existing ones, e.g.: I suggest the following:
Extra non-generic settings such as What do you think? |
|
/ready-for-reviewer |
|
Hi, I missed your comment.
I agree, and since there isn't that much content on the lock screen like in the other parts of Windows where there are styler mods - The taskbar, the Start menu, Explorer, Settings - maybe there isn't much need for one. What would a theme do that isn't already possible with the existing mods?
A styler mod won't be able to achieve that, but it definitely could be a new mod. Or you could also suggest it as an enhancement to one of the existing mods. |
|
Well in that case, do you think I should resubmit this as a "Lock Screen Clock" mod rather than a "styler" mod? This mod does come with configs that enable the depth effect and let users change their font and offset and size. |
|
Yes, that was my suggestion. |
|
To be clear: I'm mostly concerned about the usage of XAML Diagnostics which caused problems and incompatibilities in other styler mods in the past, and might be unnecessary and perhaps an overkill in this case for the options that are not the universal styles ( Regarding the name, I think calling it "Styler" might be confusing for users who'd expect a styler-type mod with themes, targets, and styles, while this mod provides more accessible and convenient customization options. Let me know what you think. |

Based off of Start Menu Styler: Lock Screen Styler!
Mod authorship
If this pull request introduces a new mod, please complete the section below.
This mod was created by:
Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.