Skip to content

Add mod: Windows 11 Lock Screen Styler - #6413

Open
ZACHARIAgs wants to merge 5 commits into
ramensoftware:mainfrom
ZACHARIAgs:Add-Lock-Screen-Styler-Mod
Open

ZACHARIAgs wants to merge 5 commits into
ramensoftware:mainfrom
ZACHARIAgs:Add-Lock-Screen-Styler-Mod

Conversation

@ZACHARIAgs

Copy link
Copy Markdown

Based off of Start Menu Styler: Lock Screen Styler!

Mod authorship

If this pull request introduces a new mod, please complete the section below.

This mod was created by:

    • The submitter, without AI assistance
    • The submitter, with AI assistance
    • Claude
    • ChatGPT
    • Gemini
    • Another AI (please specify):
    • Other (please specify):

Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.

Based off of Start Menu Styler: Lock Screen Styler!
@windhawk-reviewer windhawk-reviewer Bot added the waiting-for-author The author's turn: request an AI review, or respond to one that was posted. label Oct 19, 2026
@windhawk-reviewer

Copy link
Copy Markdown

Thanks for the pull request! This repository uses a two-stage review: an AI review that you run yourself, followed by a human review.

To get started, comment /ai-review. Once you're happy with the result, comment /ready-for-reviewer to hand it over to a human reviewer.

See the pull request review process for the full details.

@ZACHARIAgs

Copy link
Copy Markdown
Author

/ai-review

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-ai-review An AI review was requested and is being prepared. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 19, 2026
@windhawk-reviewer

Copy link
Copy Markdown

Submission review

Note: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding.

Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it.

Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.


The styling engine is a near-verbatim copy of the Start Menu Styler's, with one addition: a BlackThreshold option for WindhawkBlur. Most of the issues are in the new settings layer on top of it.

1. Custom styles are silently dropped, and leftover migration code causes bugs (lines 7030–7071, 7602, 7014–7028, 7223–7259, 7341–7342)

IsLegacyPresetStyle throws away a user's controlStyles entry when it matches a list of common strings, and it does this for any target. So FontWeight=Bold, FontWeight=Light, FontWeight=Normal, FontSize=30, FontSize=54, Foreground=#FFFFFFFF, TextWrapping=NoWrap, MaxWidth=9999 and FontFamily=Bahnschrift never apply, whatever element they're written for. The only trace is a log line. It also drops any style that matches a Solid-Mist theme style for the same target (for example Grid#MediaTransportControls → Width=310). For a styler that offers custom styles, that's a real bug.

This and the other "legacy" handling exist to migrate from versions 1.4 and earlier, which were never published in the catalog. Nobody has those settings, so please remove all of it:

  • IsLegacyPresetStyle and the inlined custom-styles loop (7573–7623). Call the existing ProcessSingleTargetStylesFromSettings (line 6684, currently unused) instead, as the Start Menu Styler does.
  • The theme-name aliases in GetSelectedTheme ("Solid Mist", "Space-Black", "Space Black Simple", …). Only the two $options values can be stored.
  • hasV14Settings / hasV15Settings. These have a visible effect: hasV14Settings is "time font is non-empty". If a user clears Font family, for example to get the default font back, the clock and date offsetY settings are silently ignored and forced to -310 / 430 (lines 7258–7259, 7341–7342). hasV15Settings checks a dropdown value that is never empty, so every branch that depends on it is dead code.

2. The dedicated settings can't be turned off, and they override custom styles (lines 7216–7547, 7625–7633)

ApplyDirectModuleSettings runs unconditionally, including with Theme: None, and its rules are added last. FindElementPropertyOverrides (4421–4526) walks the rules in reverse, so the last rule added wins for each property. This has two effects:

  • There is no way to keep the stock lock screen. With the defaults, the clock always moves up 310 px and gets a 390 px font, the date moves down 430 px with a hard-coded Margin=0,-160,0,0, fonts change, widgets are hidden, and the media card gets a new background, corner radius and artwork zoom.
  • A user's own controlStyles can't override any property these rules set. For example, TextBlock#Time with Foreground=…, FontSize=… or RenderTransform=… loses to the dedicated rules. That contradicts the README ("create your own custom styles") and the None description.

Suggested fix:

  • Add the rules in the order theme → dedicated settings → controlStyles, so custom styles always win.
  • Have the dedicated settings emit only what the user actually changed. Either give each group an Enable toggle (off by default), or treat neutral values (scale 100, offset 0, empty font, Default weight, …) as "don't touch".
  • Move the theme's design values (the 390/450 font sizes, the -310/430 offsets, hidden widgets) into the theme tables, which is where theme-specific styling lives in the other stylers.

3. Global XAML state is released by automatic destructors when LockApp exits (lines 1128, 1196–1197, 1376–1380, 1471–1472)

g_elementsCustomizationState (original and applied property values), g_elementsCustomizationRules (resolved values), g_originalResourceValues and g_resourceVariablesThemeDict all hold strong XAML references. On a normal unload, UninitializeSettingsAndTap releases them on the UI thread, which is correct. But when LockApp.exe itself exits, their automatic destructors release them on the shutdown thread, possibly after XAML has been torn down. See https://github.com/ramensoftware/windhawk/wiki/Global-objects-and-process-shutdown#4-xaml-and-other-ui-thread-objects.

  • Use [[clang::no_destroy]]: the bare attribute for the nullable ResourceDictionary, and std::optional<…> for the maps, with reset() in UninitializeSettingsAndTap and emplace() in InitializeSettingsAndTap.
  • A related case: CreateNoiseStream caches a thread_local InMemoryRandomAccessStream (about 256 KB) on LockApp's UI thread. The Crystal Glass style uses it. A thread_local destructor doesn't run on unload while that thread is alive, so the stream leaks on every disable or update. Generate the stream per brush, or keep the cache in a global that UninitializeSettingsAndTap releases.

This code is inherited unchanged from the Start Menu Styler engine (none of the stylers use no_destroy yet). The maintainer may prefer to fix it in the shared engine and have you sync. I'm listing it so it's tracked.

4. The default font isn't part of Windows

The clock and date both default to Vipnagorgialla, Vipnagorgialla Rg, and the README describes the default "Space Black" theme in terms of that font. Windows doesn't ship it, so on almost every machine XAML silently falls back to another font, and the default look doesn't match the description. Either say in the README that the font must be installed, with a link to it, or default to a font that ships with Windows (the code already uses Bahnschrift as the Solid-Mist fallback).

5. Single author

@author ZACHARIAgs, Acercandr0, m417z: Windhawk mods have one author, the submitter, so this should be ZACHARIAgs. Credit m417z (engine) and Acercandr0 (Solid-Mist theme) in the README. They're only credited in a source comment right now (lines 18–22), which users never see.

6. Add a screenshot

This is a purely visual mod, and the README has no image. Please add a screenshot of each theme (hosted on i.imgur.com or raw.githubusercontent.com) so users can see what they're installing.

Optional improvements

Minor polish — none of this affects users, so it's your call.

  • Leftovers from the Start Menu Styler:
    • RunFromWindowThreadViaPostMessage (7777–7832) was only used for SearchHost and is unused here.
    • ProcessSingleTargetStylesFromSettings (6684) is unused until item 1 is fixed.
    • The StartMenu: prefix in AdjustTypeName (6521) has no meaning in LockApp.
    • -lversion in @compilerOptions is no longer needed now that IsMainModuleVersionAtLeast / VerQueryValue are gone.
  • The two theme tables are byte-identical. g_themeSolidMist (335–376) and g_themeSpaceBlack (378–419) are the same. Share one table, or make them actually differ (see the functionality notes).
  • CreateWindowExW hook (8018–8024): the other stylers only hook CreateWindowInBand(Ex) to catch the CoreWindow. If LockApp needs the extra hook, add a comment explaining why. If it doesn't, drop it.
  • README: the custom styles (controlStyles, styleConstants, themeResourceVariables) aren't documented. Link to the Start Menu Styler / taskbar styling guide for the syntax, list a few known LockApp targets (TextBlock#Time, TextBlock#Date, Grid#MediaTransportControls, …), and document the new BlackThreshold parameter of WindhawkBlur.

Functionality notes

Non-critical observations and ideas about the feature behavior itself.

  • Positions and sizes are tuned for one screen size. The default 390 px clock font, offsetY: -310 and the date at +430 ("places the date at the very bottom") are fixed values in effective pixels. They only line up at one effective resolution. On smaller ones, such as 1080p at 150% (720 px tall) or 1366×768, the date can end up off-screen or overlap the clock. Anchoring the date with alignment, rather than a fixed translate, would hold up better. Also, timeHeightDeltaCompensation (7348) uses a hard-coded 390, but Solid-Mist's base size is 450, so with Solid-Mist the date moves about 39 px away from where its configured offset should put it.

  • The theme choice changes very little. The two theme tables are identical, and the dedicated settings override most of their rules (media card background, border and corner radius, widget visibility, thumbnail transform, panel alignment). What's left is the base clock size and weight, plus swapping solid white for a blur foreground under Solid-Mist. Solid-Mist's Bahnschrift / Segoe UI fonts only apply when the font field is empty, which never happens with the defaults (and triggers the offset bug from item 1). The README's "clock near the top, date at the very bottom" for Space Black comes from the offset settings and applies to every theme.

  • BlackThreshold mask rendering (2865–2910):

    • Stage 2 runs ColorMatrixEffect in premultiplied mode. The output (cr·m, cg·m, cb·m, op·m) is treated as straight color and premultiplied again. As a result, partially masked pixels (anti-aliased edges, pixels near the threshold) come out darker or grayer, and a tint alpha below 1 darkens the color, because cr already includes op. Putting the straight tint in the bias row (m2[16..18] = R, G, B, m2[3] = op, everything else 0) gives correctly premultiplied output.
    • With BlackThreshold set, the blur, saturation, noise and tint stages are still built and then thrown away. If a custom style combines BlackThreshold with NoiseOpacity, NoiseSource is bound (2918–2921) to a graph that no longer contains it. Returning early from the mask branch avoids both.
    • In BlackMask (and the glass styles), TintOpacity is hard-coded (7143), so the alpha of a #AARRGGBB color is ignored, even though the setting's description offers that format.
  • Overlap with existing mods. The closest ones are:

    • Windows 11 Start Menu Styler: it can already style LockApp.exe with custom styles if the user adds it to its process list, and Lock Screen Date and Time Format's README recommends exactly that.
    • Lock Screen Date and Time Format itself, which only changes the text format.

    This mod's distinct value is the dedicated lock-screen settings UI and themes. Both stylers use XAML Diagnostics, and only one diagnostics consumer works per process. A README note telling users to remove LockApp.exe from the Start Menu Styler's process list if they had set that up would prevent a confusing "one of them does nothing" situation.

Code overview

For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit 3514e11. This mod is new, so everything below is new. The engine regions (roughly lines 423–7012) are the Start Menu Styler engine with the Start-menu-specific parts (WebView styling, AllApps workarounds, layout feature flags, separate pinned scroll) removed and BlackThreshold added.

Code regions

  • Line 1–11: metadata (@include LockApp.exe, @architecture x86-64).
  • Line 13–22: license comment and credits (m417z engine, Acercandr0 Solid-Mist).
  • Line 24–65: README (dedicated settings and the two themes).
  • Line 67–311: settings: theme, timeSettings, dateSettings, mediaSettings, batterySettings, extraSettings, plus the generic styleConstants / controlStyles / themeResourceVariables.
  • Line 313–421: Theme structs and the two built-in theme tables (Solid-Mist 335–376, Space Black 378–419; identical contents).
  • Line 423–796: XAML Diagnostics plumbing: VisualTreeWatcher (467–607) delivers element add/remove events to ApplyCustomizations / CleanupCustomizations, WindhawkTAP (616–665), exported DllGetClassObject / DllCanUnloadNow (706–737), InjectWindhawkTAP → InitializeXamlDiagnosticsEx (747–792).
  • Line 799–1458: engine types and global state: rule matching, per-element customization state (1122–1213), style-variable registry (1215–1276), image-retry state (1280–1351), resource-variable state (1353–1384), the ReadLocalValueWithWorkaround property-read helper (1386–1457), in-memory noise bitmap generator with a thread_local cache (1459–1539).
  • Line 1541–3027: WindhawkBlur brush. D2D effect wrappers (Composite / Flood / Border / GaussianBlur / ColorMatrix, 1616–2408). XamlBlurBrush implementation (2410–3026), including the energy-saver fallback watch (2534–2629) and the effect graph CreateEffectBrush (2743–2924), with the new black-key mask at 2865–2910.
  • Line 3028–3270: retries ImageBrush loads with remote sources after connectivity changes.
  • Line 3270–6305: style parsing and application: SetOrClearValue, WindhawkBlur parameter parsing including BlackThreshold (3636–3900), style-variable capture / expression evaluation, ApplyCustomizations (6104), CleanupCustomizations (6175).
  • Line 6306–6724: style constants, target/rule parsing (ElementMatcherFromString, ParseRule, AdjustTypeName), AddElementCustomizationRules (6665), and the unused ProcessSingleTargetStylesFromSettings (6684–6723).
  • Line 6725–7012: theme resource variables (parse, merge into Application::Resources, refresh on ColorValuesChanged).
  • Line 7014–7071: theme selection, including legacy name aliases, and IsLegacyPresetStyle, which filters user styles.
  • Line 7073–7547: dedicated settings → rules: hex color normalization, font weight mapping, BuildTextForegroundStyle (the nine render styles), ApplyDirectModuleSettings (time, date, media, battery, widgets / Spotlight overlays).
  • Line 7549–7723: ProcessAllStylesFromSettings (theme → filtered controlStyles → dedicated settings → resource variables), uninit/init of settings and the TAP.
  • Line 7725–7994: RunFromWindowThread helpers (the PostMessage variant is unused), OnWindowCreated plus hooks on CreateWindowInBand / CreateWindowInBandEx / CreateWindowExW to catch Windows.UI.Core.CoreWindow, and GetCoreWnd (EnumWindows filtered by PID).
  • Line 7996–8082: Wh_ModInit (hooks resolved from user32.dll loaded with LOAD_LIBRARY_SEARCH_SYSTEM32), Wh_ModAfterInit / Wh_ModUninit / Wh_ModSettingsChanged (run init/uninit on the CoreWindow thread).

Side effects of interest

  • Line 2577–2627, 2966–2986: registry read: HKLM\SYSTEM\CurrentControlSet\Control\Power, value EnergySaverState. Queried, and watched with RegNotifyChangeKeyValue + RegisterWaitForSingleObject, only for WindhawkBlur brushes that specify a FallbackColor (none of the built-in themes or dedicated settings do). Read-only. The watch is removed in the brush destructor (2658–2676).
  • Line 3034–3270: network access: none started by the mod itself. If a user's custom style sets an ImageBrush to a remote URL, XAML downloads it, and the mod checks connectivity (NetworkInformation::GetInternetConnectionProfile) and subscribes to NetworkStatusChanged to retry failed loads. The defaults don't use remote images.
  • Line 2539–2570, 7002–7011: IPC: WinRT system-notification subscriptions: UISettings.AdvancedEffectsEnabledChanged and PowerManager.EnergySaverStatusChanged (per fallback-enabled blur brush), and UISettings.ColorValuesChanged (when resource variables reference theme resources). Revoked on brush destruction or uninit.
  • Line 747–792: other reach outside the process: InitializeXamlDiagnosticsEx loads this mod's DLL as a XAML Diagnostics TAP in LockApp.exe, trying connection names VisualDiagConnection1…10000. Only one diagnostics consumer works per process.
  • Line 7748–7772: other reach outside the process: SetWindowsHookEx(WH_CALLWNDPROC) scoped to LockApp's own CoreWindow thread, removed right after the SendMessage. Used by Wh_ModAfterInit, Wh_ModUninit and Wh_ModSettingsChanged.


Next steps:

  • /ai-review - after pushing fixes, to get a review of the updated code. You can repeat this as many times as you need, but each review is thorough and usually there's no need for more than 2-3 iterations.
  • /ready-for-reviewer - once you're satisfied with the state of the pull request, to hand it over to a human reviewer. If some findings above are left unaddressed, add a short note explaining why.

See the review process for details.

Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)".

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-ai-review An AI review was requested and is being prepared. labels Oct 19, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

/ai-review

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-ai-review An AI review was requested and is being prepared. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 19, 2026
@windhawk-reviewer

Copy link
Copy Markdown

Submission review

Note: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding.

Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it.

Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.


Most of the first round is fixed:

  • the legacy-style filter and migration code are gone;
  • the dedicated settings now have Enable toggles and are added before controlStyles, so custom styles win;
  • the default font is Segoe UI, @author is a single name, and the README has a screenshot (the URL resolves);
  • the thread_local noise-stream cache is gone, and the leftovers from the Start Menu Styler are removed;
  • the BlackThreshold mask now premultiplies correctly and returns early.

Two items remain.

1. [[clang::no_destroy]]: wrong form on the XAML-holding containers, and not needed on the plain-value ones (lines 849–1224, 7201–7258)

The attribute is now on every container as a bare attribute, and the cleanup was changed from .clear() to x = {}. For a standard container, x = {} calls operator=(std::initializer_list), which works like clear(): the elements are destroyed, but the bucket array or capacity is kept. With the destructor suppressed, that memory is never freed, so it leaks on every disable or update. See https://github.com/ramensoftware/windhawk/wiki/Global-objects-and-process-shutdown#5-containers-of-resource-owning-or-thread-affine-elements.

  • These hold XAML objects and do need the attribute, but in the std::optional form:

    • g_elementsCustomizationState (1037)
    • g_elementsCustomizationRules (969)
    • g_originalResourceValues (1217)
    • g_styleVariableState (1097), which holds DependencyProperty references

    A container isn't nullable, so the only complete release is running its destructor, which reset() does:

    [[clang::no_destroy]] std::optional<
        std::unordered_map<InstanceHandle, ElementCustomizationState>>
        g_elementsCustomizationState{std::in_place};
    
    // Accesses become g_elementsCustomizationState->find(...), etc.
    // UninitializeSettingsAndTap: g_elementsCustomizationState.reset();
    // InitializeSettingsAndTap, before ProcessAllStylesFromSettings():
    //     g_elementsCustomizationState.emplace();
  • These only hold plain values, so remove the attribute:

    • g_elementTreeNodes (849): weak_ptr values
    • g_pendingStyleVariablePropagations (1113)
    • g_imageRetryDispatchers (1187): weak_ref values
    • g_resourceVariables (1213)

    Their destructors only free heap memory, which is safe at process exit. With the attribute, their buffers leak on every unload instead.

  • These are correct as they are: the bare attribute on g_visualTreeWatcher, g_resourceVariablesThemeDict and g_uiSettings (nullable, released with = nullptr), and on the thread_local g_trackedImageBrushesForThread.

2. The AdviseVisualTreeChange thread is never waited for (lines 350–365)

I missed this in the previous round. The VisualTreeWatcher constructor starts a thread to call AdviseVisualTreeChange and closes its handle immediately. Nothing waits for it to finish. That thread runs mod code after the call returns (watcher->Release(), which may run the destructor, then Wh_Log). The advise waits on the UI thread, and the code comment says it can hang. If the mod is disabled or updated before the thread finishes, the DLL is unmapped while the thread is still in it, and LockApp crashes. A new watcher, and a new thread, is created on every settings change, so this can happen after any settings change, not only at startup.

Fix:

  • Keep the thread handles instead of closing them, guarded by a mutex because the constructor runs on the UI thread.
  • In Wh_ModUninit, which runs on the engine thread, wait for all of them and close them before returning.
  • Never wait on them from the UI thread: the advise needs the UI thread, so that would deadlock.

This is inherited unchanged from the Start Menu Styler engine. The maintainer may prefer to fix it in the shared engine.

Optional improvements

Minor polish — none of this affects users, so it's your call.

  • @description still says "with styles and themes", but the mod no longer has themes.
  • The README's syntax link points to the Start Menu Styler's C++ source. https://windhawk.net/mods/windows-11-start-menu-styler (its Advanced styling section) shows the same documentation rendered.

Functionality notes

Non-critical observations and ideas about the feature behavior itself.

  • The default positions are tuned for one screen size. The 390 px clock, offsetY: -310, and the date at +430 are fixed values in effective pixels. On smaller effective resolutions, such as 1080p at 150% (720 px tall) or 1366×768, the date can end up off-screen or overlap the clock. Anchoring the date with alignment, rather than a fixed translate, would hold up better.
  • Date customization on, clock customization off. The date then loses the -160 margin and the size compensation, but keeps the default offsetY: 430. That value is tuned for the custom 390 px clock layout. With the stock clock, the date moves 430 px below its normal position, probably not "near the bottom" as the description says. One option is a different default offset when the clock customization is off. Another is to say in the setting's description that 430 assumes the custom clock.

Code overview

For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit 399e5fc. This mod is new, so everything below is new. The engine regions (roughly lines 255–6820) are the Start Menu Styler engine with the Start-menu-specific parts (WebView styling, AllApps workarounds, layout feature flags, separate pinned scroll) removed, BlackThreshold added, and [[clang::no_destroy]] added to the globals.

Code regions

  • Line 1–11: metadata (@include LockApp.exe, @architecture x86-64).
  • Line 13–19: license comment and engine credit.
  • Line 21–78: README: default layout, dedicated settings, custom-style targets, BlackThreshold, compatibility note about the Start Menu Styler, credits.
  • Line 80–253: settings: timeSettings and dateSettings (each with an enabled toggle), extraSettings (hide widgets / Spotlight overlays), and the generic styleConstants / controlStyles / themeResourceVariables.
  • Line 255–637: XAML Diagnostics plumbing: VisualTreeWatcher (308–446; it sends element add/remove events to ApplyCustomizations / CleanupCustomizations, and its constructor starts the advise thread, 350–365), WindhawkTAP (457–504), exported DllGetClassObject / DllCanUnloadNow (547–578), InjectWindhawkTAP → InitializeXamlDiagnosticsEx (588–633).
  • Line 638–1299: engine types and global state (now with [[clang::no_destroy]]): element tree nodes (837–935), customization rules and per-element state (963–1054), style-variable registry (1056–1117), image-retry state (1121–1192), resource-variable state (1194–1225), the ReadLocalValueWithWorkaround property-read helper (1227–1298).
  • Line 1300–1368: in-memory noise bitmap, now generated per brush (no cache).
  • Line 1370–2853: WindhawkBlur brush. D2D effect wrappers (1444–2236). XamlBlurBrush implementation (2238–2852), including the energy-saver fallback watch (2362–2457) and CreateEffectBrush (2571–2751), whose black-key mask path (2585–2629) returns early.
  • Line 2855–3287: retries ImageBrush loads with remote sources after connectivity changes.
  • Line 3288–6132: style parsing and application: SetOrClearValue, WindhawkBlur parameter parsing including BlackThreshold (3463–3727, BlackThreshold at 3664–3671), style-variable capture / expression evaluation, ApplyCustomizations (5931), CleanupCustomizations (6002).
  • Line 6133–6543: style constants, target/rule parsing, AddElementCustomizationRules (6484), ProcessSingleTargetStylesFromSettings (6503–6542).
  • Line 6544–6820: theme resource variables (parse, merge into Application::Resources, refresh on ColorValuesChanged).
  • Line 6822–6960: helpers for the dedicated settings: hex color normalization and alpha extraction, font-weight mapping, BuildTextForegroundStyle (the nine render styles).
  • Line 6962–7165: ApplyDirectModuleSettings: panel alignment when either module is enabled, clock rules (enabled-gated, emitting only non-neutral values), date rules (hide, or style with offset compensation), widget / Spotlight hiding.
  • Line 7167–7278: ProcessAllStylesFromSettings (dedicated settings → controlStyles → resource variables), uninit/init of settings and the TAP.
  • Line 7280–7455: RunFromWindowThread, OnWindowCreated plus hooks on CreateWindowInBand / CreateWindowInBandEx to catch Windows.UI.Core.CoreWindow, and GetCoreWnd (EnumWindows filtered by PID).
  • Line 7457–7535: Wh_ModInit (hooks resolved from user32.dll loaded with LOAD_LIBRARY_SEARCH_SYSTEM32), Wh_ModAfterInit / Wh_ModUninit / Wh_ModSettingsChanged (run init/uninit on the CoreWindow thread).

Side effects of interest

  • Line 2405–2455, 2793–2814: registry read: HKLM\SYSTEM\CurrentControlSet\Control\Power, value EnergySaverState. Queried, and watched with RegNotifyChangeKeyValue + RegisterWaitForSingleObject, only for WindhawkBlur brushes that specify a FallbackColor (the dedicated settings never do). Read-only. The watch is removed in the brush destructor (2486–2504).
  • Line 2861–3097: network access: none started by the mod itself. If a user's custom style sets an ImageBrush to a remote URL, XAML downloads it, and the mod checks connectivity (NetworkInformation::GetInternetConnectionProfile) and subscribes to NetworkStatusChanged to retry failed loads. The defaults don't use remote images.
  • Line 2367–2403, 6814–6819: IPC: WinRT system-notification subscriptions: UISettings.AdvancedEffectsEnabledChanged and PowerManager.EnergySaverStatusChanged (per fallback-enabled blur brush), and UISettings.ColorValuesChanged (when resource variables reference theme resources). Revoked on brush destruction or uninit.
  • Line 588–633: other reach outside the process: InitializeXamlDiagnosticsEx loads this mod's DLL as a XAML Diagnostics TAP in LockApp.exe, trying connection names VisualDiagConnection1…10000. Only one diagnostics consumer works per process (the README now says so).
  • Line 7303–7327: other reach outside the process: SetWindowsHookEx(WH_CALLWNDPROC) scoped to LockApp's own CoreWindow thread, removed right after the SendMessage. Used by Wh_ModAfterInit, Wh_ModUninit and Wh_ModSettingsChanged.


Next steps:

  • /ai-review - after pushing fixes, to get a review of the updated code. You can repeat this as many times as you need, but each review is thorough and usually there's no need for more than 2-3 iterations.
  • /ready-for-reviewer - once you're satisfied with the state of the pull request, to hand it over to a human reviewer. If some findings above are left unaddressed, add a short note explaining why.

See the review process for details.

Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)".

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-ai-review An AI review was requested and is being prepared. labels Oct 19, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

/ai-review

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-ai-review An AI review was requested and is being prepared. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 19, 2026
@windhawk-reviewer

Copy link
Copy Markdown

Submission review

Note: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding.

Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it.

Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.


Both items from the previous round are mostly addressed:

  • The four XAML-holding containers now use [[clang::no_destroy]] std::optional<…>, with reset() in UninitializeSettingsAndTap and emplace() in InitializeSettingsAndTap. The plain-value globals no longer have the attribute.
  • The AdviseVisualTreeChange threads are tracked, and Wh_ModUninit waits for them.

One ordering problem remains in that wait.

1. Wait for the advise threads before unadvising, not after (lines 7543–7580)

Wh_ModUninit first runs UninitializeSettingsAndTap on the UI thread, which calls UnadviseVisualTreeChange, and only then waits for the advise threads. Here is how that can fail:

  1. An advise is still pending, for example because the mod was disabled right after loading or right after a settings change.
  2. UninitializeSettingsAndTap unadvises a watcher that isn't advised yet. That call does nothing.
  3. The pending AdviseVisualTreeChange then completes. XAML Diagnostics now holds an advised watcher that nothing will ever unadvise.

The wait only makes sure the thread itself has left the DLL. Once the DLL is unloaded, the next visual tree change calls into unmapped code and crashes LockApp.

Wh_ModSettingsChanged has the same race without even waiting. The old watcher can be advised after UninitializeSettingsAndTap unadvised it. Two watchers are then active, both apply styles, and the old one is never unadvised. Also, the handles of finished threads pile up in g_adviseThreads until the mod unloads.

Fix: wait at the start of both callbacks, on the engine thread, before RunFromWindowThread. That's safe because the advise only needs the UI thread, which is free at that point:

void WaitForAdviseThreads() {
    std::vector<HANDLE> threads;
    {
        std::lock_guard<std::mutex> lock(g_adviseThreadsMutex);
        threads.swap(g_adviseThreads);
    }
    for (HANDLE thread : threads) {
        WaitForSingleObject(thread, INFINITE);
        CloseHandle(thread);
    }
}

void Wh_ModUninit() {
    Wh_Log(L">");

    StopImageLoadRetries();
    WaitForAdviseThreads();  // Before the watcher is unadvised.

    HWND hCoreWnd = GetCoreWnd();
    ...
}

void Wh_ModSettingsChanged() {
    Wh_Log(L">");

    WaitForAdviseThreads();

    HWND hCoreWnd = GetCoreWnd();
    ...
}
Optional improvements

Minor polish — none of this affects users, so it's your call.

  • Unused theme parameters are back. LoadStyleConstants(const std::vector<PCWSTR>&) (6152–6173) and ProcessResourceVariablesFromSettings(…, const std::vector<PCWSTR>&) (6774–6789) once again take a theme list. They're only called with {} (lines 7202 and 7227), so the parameters and their loops are dead code, as they were after the previous round.

Functionality notes

Non-critical observations and ideas about the feature behavior itself.

  • This commit reverted the BlackThreshold color fix (2626–2641). Stage 2 multiplies the tint by its alpha again (cr = R·op) and outputs (cr·m, cg·m, cb·m, op·m). In the default D2D1_COLORMATRIX_ALPHA_MODE_PREMULTIPLIED mode, D2D applies the matrix to straight colors and premultiplies the result, so that output gets premultiplied a second time.

    • At full mask with an opaque tint, the result is the same as before.
    • Anti-aliased edges and pixels near the threshold fade through gray instead of fading out the tint.
    • A translucent color such as #80FFFFFF (now passed as TintOpacity) renders as 50% gray instead of white at 50% opacity.

    The previous round's matrix was correct: straight tint in the bias row (m2[16..18] = R, G, B), m2[3] = op, everything else 0. If you reverted it because something looked wrong in testing, please say what in the PR.

  • The glass styles ignore the color's alpha again (6940–6956). Frosted Glass, Crystal Glass and Chameleon Glass hard-code TintOpacity, so the alpha of a #AARRGGBB color has no effect, even though the setting's description lists glass tints. Either scale TintOpacity by the alpha, as the previous commit did, or say in the description that the alpha only applies to Solid Color, Lunar Eclipse and Black-Pixel Mask.

  • Broader targets (7088, 7097, 7179). The dedicated rules now target TextBlock#Time and TextBlock#Date, which match a TextBlock with that name anywhere in LockApp, not just the lock screen clock and date. Meanwhile, the README's "Common targets" still list the parent-qualified forms (StackPanel#TimePanel > TextBlock#Time, …). If you made this change because the parent chain differs on some builds, update the README targets too. Otherwise, the qualified targets are safer.

  • The default positions are still tuned for one screen size. On smaller effective resolutions, such as 1080p at 150% or 1366×768, the 390 px clock at -310 and the date at +430 can end up off-screen or overlap.

Code overview

For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit fe4c67e. This mod is new, so everything below is new. The engine regions (roughly lines 262–6857) are the Start Menu Styler engine with these changes:

  • the Start-menu-specific parts removed (WebView styling, AllApps workarounds, layout feature flags, separate pinned scroll);
  • BlackThreshold added;
  • [[clang::no_destroy]] std::optional<…> on the XAML-holding globals;
  • advise threads tracked and waited for in Wh_ModUninit;
  • the watcher unadvised inside UninitializeSettingsAndTap, as in the Notification Center Styler.

Code regions

  • Line 1–11: metadata (@include LockApp.exe, @architecture x86-64).
  • Line 13–19: license comment and engine credit.
  • Line 21–84: README: default "Space Black" layout, dedicated settings, custom-style syntax link and targets, BlackThreshold, note about a second XAML Diagnostics consumer, credits.
  • Line 86–259: settings: timeSettings and dateSettings (each with an enabled toggle), extraSettings (hide widgets / Spotlight overlays), and the generic styleConstants / controlStyles / themeResourceVariables.
  • Line 261–650: XAML Diagnostics plumbing.
    • VisualTreeWatcher (315–459): sends element add/remove events to ApplyCustomizations / CleanupCustomizations. Its constructor starts the advise thread and records the handle in g_adviseThreads (348–378).
    • WindhawkTAP (470–517).
    • Exported DllGetClassObject / DllCanUnloadNow (559–593).
    • InjectWindhawkTAP → InitializeXamlDiagnosticsEx (601–646).
  • Line 651–1318: engine types and global state: element tree nodes (850–948), customization rules and per-element state (976–1067, with optional-wrapped globals), style-variable registry (1069–1134), image-retry state (1138–1209), resource-variable state (1211–1244), the ReadLocalValueWithWorkaround property-read helper (1246–1318).
  • Line 1319–1386: in-memory noise bitmap, generated per brush.
  • Line 1388–2872: WindhawkBlur brush. D2D effect wrappers (1463–2255). XamlBlurBrush implementation (2257–2872), including the energy-saver fallback watch (2381–2476) and CreateEffectBrush (2590–2770), whose black-key mask path (2604–2648) returns early.
  • Line 2875–3306: retries ImageBrush loads with remote sources after connectivity changes.
  • Line 3307–6151: style parsing and application: SetOrClearValue, WindhawkBlur parameter parsing including BlackThreshold (3482–3746, BlackThreshold at 3683–3690), style-variable capture / expression evaluation, ApplyCustomizations (5950), CleanupCustomizations (6021).
  • Line 6152–6569: style constants (with an unused theme parameter), target/rule parsing, AddElementCustomizationRules (6510), ProcessSingleTargetStylesFromSettings (6529–6568).
  • Line 6570–6857: theme resource variables (parse, merge into Application::Resources, refresh on ColorValuesChanged).
  • Line 6859–6997: helpers for the dedicated settings: hex color normalization and alpha extraction, font-weight mapping, BuildTextForegroundStyle (the nine render styles).
  • Line 6999–7199: ApplyDirectModuleSettings: panel alignment when either module is enabled, TextBlock#Time rules (enabled-gated, emitting only non-neutral values), TextBlock#Date rules (hide, or style with offset compensation), widget / Spotlight hiding.
  • Line 7201–7328: ProcessAllStylesFromSettings (dedicated settings → controlStyles → resource variables). UninitializeSettingsAndTap (unadvise, restore, reset() of the optional globals) and InitializeSettingsAndTap (emplace(), then styles and TAP injection).
  • Line 7329–7504: RunFromWindowThread, OnWindowCreated plus hooks on CreateWindowInBand / CreateWindowInBandEx to catch Windows.UI.Core.CoreWindow, and GetCoreWnd (EnumWindows filtered by PID).
  • Line 7506–7580: Wh_ModInit (hooks resolved from user32.dll loaded with LOAD_LIBRARY_SEARCH_SYSTEM32), Wh_ModAfterInit / Wh_ModSettingsChanged (init/uninit on the CoreWindow thread), and Wh_ModUninit (uninit on the CoreWindow thread, then waits for and closes the advise threads).

Side effects of interest

  • Line 2424–2474, 2812–2833: registry read: HKLM\SYSTEM\CurrentControlSet\Control\Power, value EnergySaverState. Queried, and watched with RegNotifyChangeKeyValue + RegisterWaitForSingleObject, only for WindhawkBlur brushes that specify a FallbackColor (the dedicated settings never do). Read-only. The watch is removed in the brush destructor (2505–2523).
  • Line 2880–3116: network access: none started by the mod itself. If a user's custom style sets an ImageBrush to a remote URL, XAML downloads it, and the mod checks connectivity (NetworkInformation::GetInternetConnectionProfile) and subscribes to NetworkStatusChanged to retry failed loads. The defaults don't use remote images.
  • Line 2381–2422, 6851–6856: IPC: WinRT system-notification subscriptions: UISettings.AdvancedEffectsEnabledChanged and PowerManager.EnergySaverStatusChanged (per fallback-enabled blur brush), and UISettings.ColorValuesChanged (when resource variables reference theme resources). Revoked on brush destruction or uninit.
  • Line 601–646: other reach outside the process: InitializeXamlDiagnosticsEx loads this mod's DLL as a XAML Diagnostics TAP in LockApp.exe, trying connection names VisualDiagConnection1…10000. Only one diagnostics consumer works per process (the README says so).
  • Line 7352–7376: other reach outside the process: SetWindowsHookEx(WH_CALLWNDPROC) scoped to LockApp's own CoreWindow thread, removed right after the SendMessage. Used by Wh_ModAfterInit, Wh_ModUninit and Wh_ModSettingsChanged.


Next steps:

  • /ai-review - after pushing fixes, to get a review of the updated code. You can repeat this as many times as you need, but each review is thorough and usually there's no need for more than 2-3 iterations.
  • /ready-for-reviewer - once you're satisfied with the state of the pull request, to hand it over to a human reviewer. If some findings above are left unaddressed, add a short note explaining why.

See the review process for details.

Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)".

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-ai-review An AI review was requested and is being prepared. labels Oct 19, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

/ai-review

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-ai-review An AI review was requested and is being prepared. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 19, 2026
@windhawk-reviewer

Copy link
Copy Markdown

This pull request has already had 3 AI reviews in the last 24 hours, which is the limit, so no review was posted this time.

Comment /ai-review again after 2026-10-20 19:41 UTC (in 22 hours) to get another one.

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-ai-review An AI review was requested and is being prepared. labels Oct 19, 2026
@windhawk-reviewer windhawk-reviewer Bot removed the waiting-for-ai-review An AI review was requested and is being prepared. label Oct 20, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

/ai-review

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-ai-review An AI review was requested and is being prepared. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 20, 2026
@windhawk-reviewer

Copy link
Copy Markdown

This pull request has already had 3 AI reviews in the last 24 hours, which is the limit, so no review was posted this time.

Comment /ai-review again after 2026-10-20 20:48 UTC (in 33 minutes) to get another one.

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-ai-review An AI review was requested and is being prepared. labels Oct 20, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

/ai-review

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-ai-review An AI review was requested and is being prepared. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 20, 2026
@windhawk-reviewer

Copy link
Copy Markdown

Submission review

Note: This review was done by Claude. Due to the amount of submissions, doing a fully manual review for each pull request is no longer feasible. Thank you for understanding.

Remember: The AI reviewer can be wrong - it may misread code, flag correct code as broken, or suggest changes that make things worse. Treat its findings as suggestions to verify, not instructions to follow blindly. You're responsible for the code you submit, so if a finding doesn't hold up, say so instead of changing working code to satisfy it.

Please address the following issues. The items in the collapsed sections are optional, so it's your call whether to address them.


No blocking issues — looks good to merge. Everything from the previous round is addressed:

  • Advise threads: WaitForAdviseThreads() now runs at the start of Wh_ModUninit and Wh_ModSettingsChanged, before the watcher is unadvised. A pending advise can no longer leave a watcher registered, and finished thread handles don't pile up.
  • BlackThreshold mask: it outputs the straight tint (m2[16..18] = R, G, B, m2[3] = op), so D2D premultiplies it exactly once.
  • Glass styles: they scale TintOpacity by the color's alpha.
  • Targets: the dedicated rules are back to StackPanel#TimePanel > TextBlock#Time and StackPanel#TimeAndDatePanel > TextBlock#Date, matching the README.
  • Dead code: the unused theme parameters on LoadStyleConstants and ProcessResourceVariablesFromSettings are gone.
Functionality notes

Non-critical observations and ideas about the feature behavior itself.

  • The default positions are tuned for one screen size. The 390 px clock at offsetY: -310 and the date at +430 are fixed values in effective pixels. On smaller effective resolutions, such as 1080p at 150% (720 px tall) or 1366×768, the date can end up off-screen or overlap the clock. Anchoring the date with alignment, rather than a fixed translate, would hold up better. Alternatively, the README could mention the screen size the defaults were designed for.

Code overview

For the maintainer: a map of the mod and what it touches outside its own process. Descriptive only — anything that needs a change is listed above. Line numbers refer to the mod source at commit c2226cd. This mod is new, so everything below is new. The engine regions (roughly lines 262–6838) are the Start Menu Styler engine with these changes:

  • the Start-menu-specific parts removed (WebView styling, AllApps workarounds, layout feature flags, separate pinned scroll);
  • BlackThreshold added;
  • [[clang::no_destroy]] std::optional<…> on the XAML-holding globals;
  • advise threads tracked and waited for before unadvising;
  • the watcher unadvised inside UninitializeSettingsAndTap, as in the Notification Center Styler.

Code regions

  • Line 1–11: metadata (@include LockApp.exe, @architecture x86-64).
  • Line 13–19: license comment and engine credit.
  • Line 21–84: README: default "Space Black" layout, dedicated settings, custom-style syntax link and targets, BlackThreshold, note about a second XAML Diagnostics consumer, credits.
  • Line 86–259: settings: timeSettings and dateSettings (each with an enabled toggle), extraSettings (hide widgets / Spotlight overlays), and the generic styleConstants / controlStyles / themeResourceVariables.
  • Line 261–650: XAML Diagnostics plumbing.
    • VisualTreeWatcher (315–459): sends element add/remove events to ApplyCustomizations / CleanupCustomizations. Its constructor starts the advise thread and records the handle in g_adviseThreads (348–378).
    • WindhawkTAP (470–517).
    • Exported DllGetClassObject / DllCanUnloadNow (559–593).
    • InjectWindhawkTAP → InitializeXamlDiagnosticsEx (601–646).
  • Line 651–1318: engine types and global state: element tree nodes (850–948), customization rules and per-element state (976–1067, with optional-wrapped globals), style-variable registry (1069–1134), image-retry state (1138–1209), resource-variable state (1211–1244), the ReadLocalValueWithWorkaround property-read helper (1246–1318).
  • Line 1319–1386: in-memory noise bitmap, generated per brush.
  • Line 1388–2872: WindhawkBlur brush. D2D effect wrappers (1463–2255). XamlBlurBrush implementation (2257–2871), including the energy-saver fallback watch (2381–2476) and CreateEffectBrush (2590–2769), whose black-key mask path (2604–2647) returns early.
  • Line 2874–3305: retries ImageBrush loads with remote sources after connectivity changes.
  • Line 3306–6150: style parsing and application: SetOrClearValue, WindhawkBlur parameter parsing including BlackThreshold (3481–3745, BlackThreshold at 3682–3689), style-variable capture / expression evaluation, ApplyCustomizations (5949), CleanupCustomizations (6020).
  • Line 6151–6561: style constants, target/rule parsing, AddElementCustomizationRules (6502), ProcessSingleTargetStylesFromSettings (6521–6560).
  • Line 6562–6838: theme resource variables (parse, merge into Application::Resources, refresh on ColorValuesChanged).
  • Line 6840–6981: helpers for the dedicated settings: hex color normalization and alpha extraction, font-weight mapping, BuildTextForegroundStyle (the nine render styles; the alpha scales TintOpacity).
  • Line 6983–7183: ApplyDirectModuleSettings: panel alignment when either module is enabled, clock rules (enabled-gated, emitting only non-neutral values), date rules (hide, or style with offset compensation), widget / Spotlight hiding.
  • Line 7185–7312: ProcessAllStylesFromSettings (dedicated settings → controlStyles → resource variables). UninitializeSettingsAndTap (unadvise, restore, reset() of the optional globals) and InitializeSettingsAndTap (emplace(), then styles and TAP injection).
  • Line 7313–7488: RunFromWindowThread, OnWindowCreated plus hooks on CreateWindowInBand / CreateWindowInBandEx to catch Windows.UI.Core.CoreWindow, and GetCoreWnd (EnumWindows filtered by PID).
  • Line 7490–7570: Wh_ModInit (hooks resolved from user32.dll loaded with LOAD_LIBRARY_SEARCH_SYSTEM32), Wh_ModAfterInit, and WaitForAdviseThreads (7527–7537). Wh_ModUninit and Wh_ModSettingsChanged wait for the advise threads, then run uninit/init on the CoreWindow thread.

Side effects of interest

  • Line 2424–2474, 2811–2832: registry read: HKLM\SYSTEM\CurrentControlSet\Control\Power, value EnergySaverState. Queried, and watched with RegNotifyChangeKeyValue + RegisterWaitForSingleObject, only for WindhawkBlur brushes that specify a FallbackColor (the dedicated settings never do). Read-only. The watch is removed in the brush destructor (2505–2523).
  • Line 2879–3115: network access: none started by the mod itself. If a user's custom style sets an ImageBrush to a remote URL, XAML downloads it, and the mod checks connectivity (NetworkInformation::GetInternetConnectionProfile) and subscribes to NetworkStatusChanged to retry failed loads. The defaults don't use remote images.
  • Line 2381–2422, 6832–6837: IPC: WinRT system-notification subscriptions: UISettings.AdvancedEffectsEnabledChanged and PowerManager.EnergySaverStatusChanged (per fallback-enabled blur brush), and UISettings.ColorValuesChanged (when resource variables reference theme resources). Revoked on brush destruction or uninit.
  • Line 601–646: other reach outside the process: InitializeXamlDiagnosticsEx loads this mod's DLL as a XAML Diagnostics TAP in LockApp.exe, trying connection names VisualDiagConnection1…10000. Only one diagnostics consumer works per process (the README says so).
  • Line 7336–7360: other reach outside the process: SetWindowsHookEx(WH_CALLWNDPROC) scoped to LockApp's own CoreWindow thread, removed right after the SendMessage. Used by Wh_ModAfterInit, Wh_ModUninit and Wh_ModSettingsChanged.


Next steps:

  • /ai-review - after pushing fixes, to get a review of the updated code. You can repeat this as many times as you need, but each review is thorough and usually there's no need for more than 2-3 iterations.
  • /ready-for-reviewer - once you're satisfied with the state of the pull request, to hand it over to a human reviewer. If some findings above are left unaddressed, add a short note explaining why.

See the review process for details.

Important: Each reply that was generated by AI must be disclosed by including the following text in the reply: "Generated by AI. Model: (ai-model-name)".

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-ai-review An AI review was requested and is being prepared. labels Oct 20, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

/ready-for-reviewer

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-reviewer Ready for a human reviewer, and in the queue for one. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Oct 20, 2026
@m417z

m417z commented Oct 21, 2026

Copy link
Copy Markdown
Member

Thank you for the submission. Currently, I'm the maintainer of all five XAML styler mods, and many of the fixes and improvements are applied to all of them (e.g. WindhawkBlur improvements, target and style syntax and capabilities, and more). Therefore, if there's demand for it, I prefer to be the owner of it to be able to keep all styler mods in sync.

In addition, I could create a styling guide For Settings similar to the existing ones, e.g.:
https://github.com/ramensoftware/windows-11-start-menu-styling-guide

I suggest the following:

  • I'll take this submission and release it under my ownership
  • I'll create a windows-11-lock-screen-styling-guide repo and give you permissions to add the relevant information and the first theme

Extra non-generic settings such as timeSettings are better be part of the styling guide, not as mod options, like other styler mods do that. Such options can be presented by other mods, e.g. https://windhawk.net/mods/lockscreen-datetime-format

What do you think?

@m417z m417z added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-reviewer Ready for a human reviewer, and in the queue for one. labels Oct 21, 2026
@ZACHARIAgs

Copy link
Copy Markdown
Author

Yeah, that works great. I also just saw the lock screen mods by grn15RenS and ali0zdas. I wanted to make this because there were no other mods like it, but now there are two. I think I still have valuable contributions like the depth effect (attached), but I definitely don't feel as driven now that there are alternatives out there that I can just fork from. I love your styling mods and I'm a huge fan of Windhawk and I agree that it'd be best if you take ownership of this and develop it as you see fit!

Clipboard (1)

@ZACHARIAgs

Copy link
Copy Markdown
Author

/ready-for-reviewer

@windhawk-reviewer windhawk-reviewer Bot added waiting-for-reviewer Ready for a human reviewer, and in the queue for one. and removed waiting-for-author The author's turn: request an AI review, or respond to one that was posted. labels Nov 15, 2026
@m417z

m417z commented Nov 15, 2026

Copy link
Copy Markdown
Member

Hi, I missed your comment.

I also just saw the lock screen mods by grn15RenS and ali0zdas. I wanted to make this because there were no other mods like it, but now there are two.

I agree, and since there isn't that much content on the lock screen like in the other parts of Windows where there are styler mods - The taskbar, the Start menu, Explorer, Settings - maybe there isn't much need for one. What would a theme do that isn't already possible with the existing mods?

I think I still have valuable contributions like the depth effect (attached)

A styler mod won't be able to achieve that, but it definitely could be a new mod. Or you could also suggest it as an enhancement to one of the existing mods.

@ZACHARIAgs

Copy link
Copy Markdown
Author

Well in that case, do you think I should resubmit this as a "Lock Screen Clock" mod rather than a "styler" mod? This mod does come with configs that enable the depth effect and let users change their font and offset and size.

@m417z

m417z commented Nov 16, 2026

Copy link
Copy Markdown
Member

Yes, that was my suggestion.

@m417z

m417z commented Nov 17, 2026

Copy link
Copy Markdown
Member

To be clear: I'm mostly concerned about the usage of XAML Diagnostics which caused problems and incompatibilities in other styler mods in the past, and might be unnecessary and perhaps an overkill in this case for the options that are not the universal styles (styleConstants, controlStyles, themeResourceVariables). So I think the best way forward is to update the mod to not use XAML Diagnostics, and give up on the universal styling.

Regarding the name, I think calling it "Styler" might be confusing for users who'd expect a styler-type mod with themes, targets, and styles, while this mod provides more accessible and convenient customization options.

Let me know what you think.

@m417z m417z added waiting-for-author The author's turn: request an AI review, or respond to one that was posted. and removed waiting-for-reviewer Ready for a human reviewer, and in the queue for one. labels Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-author The author's turn: request an AI review, or respond to one that was posted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants