Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make goo.gl config optional #59

Open
danielo515 opened this issue Jun 12, 2018 · 3 comments
Open

Make goo.gl config optional #59

danielo515 opened this issue Jun 12, 2018 · 3 comments

Comments

@danielo515
Copy link

Hello,

I can understand that, in order to share short urls you need the credentials for go.gl and that stuff.
But there are many use-cases where this is not required.
Any chance you make this configuration option optional instead of required ?

Regards

@danielo515 danielo515 changed the title Remove goo.gl dependency Make goo.gl configu optional Jun 12, 2018
@danielo515 danielo515 changed the title Make goo.gl configu optional Make goo.gl config optional Jun 12, 2018
@CrossEye
Copy link
Member

I don't think we'd have any issue with that if you wanted to create a PR.

@danielo515
Copy link
Author

Hello @CrossEye
I would love to, but I can't promise anything because I have lots of things to do and very little time.
In any case, seems that goo.gl is going to dissapear, see this deprecation notice:

https://developers.googleblog.com/2018/03/transitioning-google-url-shortener.html

Regards

@CrossEye
Copy link
Member

Thank you for the information. I hadn't seen it. Clearly we're going to have to make some change here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants