Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ? from hash #39

Open
MattMS opened this issue Oct 27, 2016 · 2 comments
Open

Remove ? from hash #39

MattMS opened this issue Oct 27, 2016 · 2 comments

Comments

@MattMS
Copy link
Member

MattMS commented Oct 27, 2016

Unless there is a reason that the ? is required, then it seems like parsing the code from the hash would be simpler if it didn't require removing the ? each time.

@craigdallimore
Copy link
Contributor

Agreed - at present the "try in repl" part of the ramda docs includes the ? in its links, so we probably need to account it until we fix it on that side.

@MattMS
Copy link
Member Author

MattMS commented Nov 29, 2016

There was a merged PR that changed the ? to a ; in preparation for this.
I just checked the docs page and it appears to be working.

So you should be able to include the first character and it would still be valid JS.
Then we can update the button click handler to exclude that character.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants