Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property migration dialogue doesn't broadcast 500 errors #1143

Open
joelvdavies opened this issue Nov 28, 2024 · 2 comments
Open

Property migration dialogue doesn't broadcast 500 errors #1143

joelvdavies opened this issue Nov 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@joelvdavies
Copy link
Collaborator

While testing the write conflict message (see #1121), I noticed that if a 500 is returned, the only thing that is shown is:
image
but nothing happens and no error is displayed.

@joelvdavies joelvdavies added the bug Something isn't working label Nov 28, 2024
@joshuadkitenge
Copy link
Collaborator

What did you do to the API to trigger this error? It should be working as the handleTransferState in the onError should catch all errors . However looking at the code the types might not be correct for a 500 error

@joelvdavies
Copy link
Collaborator Author

It was on ral-facilities/inventory-management-system-api#433 before I actually caught the error to raise it as a 409, so it was a 500 with the same message. I put an OperationFailure on this line https://github.com/ral-facilities/inventory-management-system-api/blob/9922030645750d2bf7aca34cd42e600c8a7b8140/inventory_management_system_api/services/catalogue_category_property.py#L109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants