Gallery view #1081 #1100
Closed
Gallery view #1081 #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 1, 2024
joshuadkitenge
force-pushed
the
gallery-view-#1081
branch
from
2a26831 to
35408f8
Compare
joshuadkitenge
force-pushed
the
gallery-view-#1081
branch
from
88339d5 to
5dc385e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1100 +/- ##
===========================================
+ Coverage 99.15% 99.20% +0.04%
===========================================
Files 82 85 +3
Lines 16922 17428 +506
Branches 2057 2896 +839
===========================================
+ Hits 16779 17289 +510
+ Misses 142 136 -6
- Partials 1 3 +2 ☔ View full report in Codecov by Sentry. |
joshuadkitenge
force-pushed
the
gallery-view-#1081
branch
from
5a666bb to
23d092f
Compare
joelvdavies
reviewed
Nov 5, 2024
joshuadkitenge
force-pushed
the
gallery-view-#1081
branch
from
daa6727 to
180761a
Compare
joshuadkitenge
commented
Nov 7, 2024
- remove max height in thumbnail - one image should have a max length of 50%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see #1081 and #1084
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
closes #1081, closes #1084