Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Dialog for Images #1151

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

asuresh-code
Copy link
Contributor

Description

#1075

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • {more steps here}

Agile board tracking

closes #1075

@asuresh-code asuresh-code self-assigned this Dec 11, 2024
@asuresh-code asuresh-code marked this pull request as draft December 11, 2024 10:10
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 69.90291% with 62 lines in your changes missing coverage. Please review.

Project coverage is 98.90%. Comparing base (718d659) to head (157ed0f).

Files with missing lines Patch % Lines
src/common/images/editImageDialog.component.tsx 74.30% 37 Missing ⚠️
src/mocks/handlers.ts 25.00% 12 Missing ⚠️
src/api/images.tsx 55.00% 9 Missing ⚠️
src/common/images/imageGallery.component.tsx 77.77% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1151      +/-   ##
===========================================
- Coverage    99.23%   98.90%   -0.34%     
===========================================
  Files           88       89       +1     
  Lines        17876    18076     +200     
  Branches      2123     2958     +835     
===========================================
+ Hits         17740    17878     +138     
- Misses         135      194      +59     
- Partials         1        4       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit images
1 participant