Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Optional types on session objects in repo functions #441

Closed
joelvdavies opened this issue Dec 9, 2024 · 0 comments · Fixed by #446
Closed

Missing Optional types on session objects in repo functions #441

joelvdavies opened this issue Dec 9, 2024 · 0 comments · Fixed by #446
Assignees
@joelvdavies
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@joelvdavies
Copy link
Collaborator

My fault 🤦‍♂️ . We have quite a few instances around this repo and object-storage-api, so this is an issue to find ClientSession = None and replace them all with Optional[ClientSession] = None.
@joelvdavies joelvdavies added enhancement New feature or request good first issue Good for newcomers labels Dec 9, 2024
@joelvdavies joelvdavies mentioned this issue Dec 9, 2024
Closed
@joelvdavies joelvdavies mentioned this issue Jan 9, 2025
Closed
@joelvdavies joelvdavies self-assigned this Jan 9, 2025
@joelvdavies joelvdavies moved this from Backlog to In Progress in Inventory Management System Jan 9, 2025
joelvdavies added a commit that referenced this issue Jan 9, 2025
@joelvdavies
Fix missing optional types on ClientSessions #441
544bc63
@joelvdavies joelvdavies mentioned this issue Jan 9, 2025
Merged
3 tasks
@joelvdavies joelvdavies moved this from In Progress to In Review in Inventory Management System Jan 9, 2025
joelvdavies added a commit that referenced this issue Jan 14, 2025
@joelvdavies
Resolve some further missing optional types #441
468cc65
joelvdavies added a commit that referenced this issue Jan 14, 2025
@joelvdavies
Merge pull request #446 from ral-facilities/fix-missing-optional-type…
329a188 
…s-session-#441

Fix missing optional types on ClientSessions #441
@github-project-automation github-project-automation bot moved this from In Review to Done in Inventory Management System Jan 14, 2025
@VKTB VKTB moved this from Done to Archive in Inventory Management System Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joelvdavies joelvdavies

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Inventory Management System
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing optional types on ClientSessions #441 ral-facilities/inventory-management-system-api
1 participant
@joelvdavies