Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return schemas from services instead of models? #424

Open
joelvdavies opened this issue Nov 22, 2024 · 0 comments
Open

Return schemas from services instead of models? #424

joelvdavies opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@joelvdavies
Copy link
Collaborator

Currently we mostly return models from service functions. This means that cases where the repo output could require further processing e.g. adding fields from other repos, or in the object-storage-api where we insert presigned urls, the database model would no longer be sufficient to hold the data. So I think it could be worth modifying so models are kept only for the repo and are used in the services, but the services themselves only return schemas.

@joelvdavies joelvdavies added the question Further information is requested label Nov 22, 2024
@joelvdavies joelvdavies added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Backlog
Development

No branches or pull requests

1 participant