Address further comments from CC repo unit tests PR #305

Author: joelvdavies

test/unit/repositories/test_catalogue_category.py

@@ -595,7 +595,7 @@ def set_update_data(self, new_catalogue_category_in_data: dict):
 
         :param new_catalogue_category_in_data: New catalogue category data as would be required for a
                          `CatalogueCategoryIn` database model to supply to the `CatalogueCategoryRepo`
-                         `update` method
+                         `update` method.
         """
         self._catalogue_category_in = CatalogueCategoryIn(**new_catalogue_category_in_data)
 
@@ -1006,7 +1006,7 @@ def mock_delete(
 
         :param deleted_count: Number of documents deleted successfully.
         :param child_catalogue_category_data: Dictionary containing a child catalogue category's data (or `None`).
-        :param child_item_data: Dictionary containing a child catalogue item's data (or `None`).
+        :param child_catalogue_item_data: Dictionary containing a child catalogue item's data (or `None`).
         """
 
         self.mock_has_child_elements(child_catalogue_category_data, child_catalogue_item_data)
@@ -1086,7 +1086,7 @@ def test_delete_with_child_catalogue_category(self):
         )
 
     def test_delete_with_child_catalogue_item(self):
-        """Test deleting a catalogue category when it has a child Catalogue Item."""
+        """Test deleting a catalogue category when it has a child catalogue item."""
 
         catalogue_category_id = str(ObjectId())
 
@@ -1225,7 +1225,7 @@ def test_create_property_with_invalid_id(self):
 class UpdatePropertyDSL(CreatePropertyDSL):
     """Base class for `update_property` tests."""
 
-    _updated_property: CatalogueCategoryOut
+    _updated_property: CatalogueCategoryPropertyOut
     _property_id: str
     _update_exception: pytest.ExceptionInfo
 

test/unit/services/test_catalogue_category.py

@@ -214,14 +214,14 @@ def mock_create(
         ServiceTestHelpers.mock_create(self.mock_catalogue_category_repository, self._expected_catalogue_category_out)
 
     def call_create(self) -> None:
-        """Calls the CatalogueCategoryService `create` method with the appropriate data from a prior call to
+        """Calls the `CatalogueCategoryService` `create` method with the appropriate data from a prior call to
         `mock_create`."""
 
         self._created_catalogue_category = self.catalogue_category_service.create(self._catalogue_category_post)
 
     def call_create_expecting_error(self, error_type: type[BaseException]) -> None:
         """
-        Calls the CatalogueCategoryService `create` method with the appropriate data from a prior call to
+        Calls the `CatalogueCategoryService` `create` method with the appropriate data from a prior call to
         `mock_create` while expecting an error to be raised.
 
         :param error_type: Expected exception to be raised.
@@ -358,7 +358,7 @@ def mock_get(self) -> None:
 
     def call_get(self, catalogue_category_id: str) -> None:
         """
-        Calls the CatalogueCategoryService `get` method.
+        Calls the `CatalogueCategoryService` `get` method.
 
         :param catalogue_category_id: ID of the catalogue category to be obtained.
         """
@@ -444,7 +444,7 @@ def mock_list(self) -> None:
 
     def call_list(self, parent_id: Optional[str]) -> None:
         """
-        Calls the CatalogueCategoryService `list` method.
+        Calls the `CatalogueCategoryService` `list` method.
 
         :param parent_id: ID of the parent catalogue category to query by, or `None`.
         """
@@ -842,7 +842,7 @@ class DeleteDSL(CatalogueCategoryServiceDSL):
 
     def call_delete(self, catalogue_category_id: str) -> None:
         """
-        Calls the CatalogueCategoryService `delete` method.
+        Calls the `CatalogueCategoryService` `delete` method.
 
         :param catalogue_category_id: ID of the catalogue category to be deleted.
         """