Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display images/thumbnails for data on cards #343

Open
1 task
GoelBiju opened this issue Jul 27, 2020 · 3 comments
Open
1 task

Display images/thumbnails for data on cards #343

GoelBiju opened this issue Jul 27, 2020 · 3 comments
Labels
datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table enhancement New feature or request not MVP not part of the minimum viable product

Comments

@GoelBiju
Copy link
Contributor

Description:
This has already been noted in the list of items to fix for the CardView but this will only be addressed once it is supported on ICAT. For the time being, code relating to images/thumbnails on cards is not being used.

Acceptance criteria:

  • Images for the data is shown on the implemented card views.
@GoelBiju GoelBiju added enhancement New feature or request datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table labels Jul 27, 2020
@GoelBiju GoelBiju mentioned this issue Jul 27, 2020
Closed
1 task
@GoelBiju
Copy link
Contributor Author

GoelBiju commented Jul 27, 2020 •
edited
Loading

A couple of tasks to do related to this is to make sure:

  • the image sizing is correct when images/thumbnails are set on the CardView and ensure it is square and not stretched unevenly,

  • width of all cards are the same (even when some cards have images and others do not).

@GoelBiju GoelBiju added the not MVP not part of the minimum viable product label Jul 27, 2020
@agbeltran
Copy link
Member

Linking to relevant issue in the ICAT schema: icatproject/icat.server#241

@agbeltran
Copy link
Member

We should include a default image for each type of entity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datagateway-dataview Issues corresponding to the dataview component. This component supersedes datagateway-table enhancement New feature or request not MVP not part of the minimum viable product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agbeltran @GoelBiju