Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display volunteer count on homepage #1030

Open
dauntlessnomad opened this issue Aug 10, 2019 · 16 comments · May be fixed by #1036
Open

Display volunteer count on homepage #1030

dauntlessnomad opened this issue Aug 10, 2019 · 16 comments · May be fixed by #1036
Labels
good first issue Good for newcomers

Comments

@dauntlessnomad
Copy link
Member

Display total registered volunteers count in the home page or sub pages will be goood

@dauntlessnomad dauntlessnomad added the good first issue Good for newcomers label Aug 10, 2019
@jerinisready
Copy link

Am working over it

@dauntlessnomad
Copy link
Member Author

https://keralarescue.in/dmodash/ .. has the stats but a volunteers count in the main page would be nice

@vigneshhari
Copy link
Member

Make sure it's not db intensive, if its on the main page

@sreenadh
Copy link

The total count is calculating in the below page for pagination purpose. Show the total there. One more thing, make the search filter "district" mandatory, otherwise, it will count the entire 75600 records from DB which is not necessary.

https://keralarescue.in/volunteerdata

@jerinisready
Copy link

Is this okey? Everything is cached!

Screenshot from 2019-08-10 13-23-09

@sreenadh
Copy link

@jerinisready How is the cache invalidated?

@jerinisready
Copy link

The total count is calculating in the below page for pagination purpose. Show the total there. One more thing, make the search filter "district" mandatory, otherwise, it will count the entire 75600 records from DB which is not necessary.

https://keralarescue.in/volunteerdata

what about applying view caching accross this data?

@jerinisready
Copy link

?

with default timeout! should i manually invalidate with updation on creation of records??

@sreenadh
Copy link

Yes. The cache should be invalidated on every update/creation of records.

Does showing the count on the home page really useful?

@jerinisready
Copy link

Yes. The cache should be invalidated on every update/creation of records.

Does showing the count on the home page really useful?

@sreenadh Probably this will take a lot of public interest. what about continuing communication at slack? share handles here @sreenadh @vigneshhari @tomahawk-pilot. so that we can take care of more issues now! including optimization.

@sreenadh
Copy link

@jerinisready which channel?

@jerinisready
Copy link

started a new one issue1030

@dauntlessnomad
Copy link
Member Author

@Syam in slack

@dauntlessnomad
Copy link
Member Author

@sreenadh all we need is a volunteer count somewhere in the main site. just to boost morale and more people will signup

@vhawk19
Copy link

vhawk19 commented Aug 10, 2019

Is this done? or is work required?

@jerinisready
Copy link

#1036

@biswaz biswaz changed the title Display volunteer count Display volunteer count on homepage Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants