Skip to content

Commit dcd8bde

Browse files
spathiwarajsite
authored andcommitted
Remove the // from leak detection output so it will cause test failures now.
TypedTemplatedLiterals.via is the last remaining leak in the Vireo test suite, but it is in a feature not currently generated by DFIR and only used internally (and this usage does not cause the leak.) Modify the test to avoid the leak, but with a TO-DO to address it in the future. (Git issue ni#378)
1 parent 8cc88c6 commit dcd8bde

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

source/core/TypeAndDataManager.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void TypeManager::PrintMemoryStat(ConstCStr message, Boolean bLast)
8585
if (bLast && (_totalAllocations == 1) && (_totalAQAllocated == sizeof(TypeManager))) {
8686
// If bLast is true then silence is success.
8787
} else {
88-
gPlatform.IO.Printf("//Allocations %4d, AQCount %5zd, ShareTypes %d (%s)\n", (int)_totalAllocations, _totalAQAllocated, _typesShared, message);
88+
gPlatform.IO.Printf("LEAKS: Allocations %4d, AQCount %5zd, ShareTypes %d (%s)\n", (int)_totalAllocations, _totalAQAllocated, _typesShared, message);
8989
}
9090
#endif
9191
}

test-it/ViaTests/TypedTemplatedLiterals.via

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ start( dv(VirtualInstrument (
1919
Println(TestPointGeneric)
2020
Println(TestPointInt8)
2121
Println(TestPointInt32)
22-
Println(TestPointComplexDouble)
22+
Println(TestPointComplexDouble<()>) // !!! without the <()> arg, this leaks! TODO(spathiwa) investigate
2323

2424
Println(TestPointInt8_2_3)
2525
Println(TestPointInt8<(2 3)>)

0 commit comments

Comments
 (0)