Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast coordinates to integers #60

Open
nukappa opened this issue Jun 14, 2016 · 5 comments
Open

cast coordinates to integers #60

nukappa opened this issue Jun 14, 2016 · 5 comments

Comments

@nukappa
Copy link
Member

nukappa commented Jun 14, 2016

probably in the merge_pAi function, some numbers have to be cast into integers

@nukappa
Copy link
Member Author

nukappa commented Jun 15, 2016

looks fine, was probably a matter of different annotation versions. a unit test has to be written to show that everything works ok.

@mschilli87 mschilli87 mentioned this issue Jun 15, 2016
4 tasks
@mschilli87
Copy link
Member

It seems there might still be a bug here: #64 (comment)

@mschilli87
Copy link
Member

Once 021f7ec is merged to master, I'll merge it into new_tests to see if this issue is finally resolved.

@nukappa
Copy link
Member Author

nukappa commented Jun 16, 2016

ok cool. I will test and merge #72 now.
related to the current issue, in one of your next pushes you can also improve the code in the merge_pAi_and_utr_intervals function: cast all start_position and end_position to integers: int(start_position). I wouldn't open a new pull request just for that. For now, even if it compares strings, i think it's doing it fine...

@mschilli87 mschilli87 changed the title find and fix bug in pAi cast coordinates to integers Jun 16, 2016
@mschilli87
Copy link
Member

mschilli87 commented Jun 16, 2016

I'll changed this issue's title & labels so we won't forget about that.

@mschilli87 mschilli87 removed their assignment Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants