Support newer versions of Code which include more color customizations

[seraku24]

• Which editor/software are you using? Visual Studio Code 1.69
• Which theme are you using? I regularly rotate through the dark (non-contrast) themes.
• Have you tested the issue with other themes? Yes, I have used the built-in themes.
• Which version of Rainglow do you have installed? 1.5.2
• Can you provide screenshots to highlight the issue? Yes, see below an example using Spearmint.

Summary

Rainglow unfortunately is out-of-date. While the general color theming still works, recent versions of Code provide more customization points. Please review the picture for reference.

The debug toolbar (see debugToolBar.*) does not match the theme, only whether the theme is considered light or dark. Text in the debug view can be hard to read as the default colors for tokens (see debugTokenExpression.*) do not agree with the rest of the theme. As mentioned in #40, Code can now color nested brackets (see editorBracketHighlight.*) which can clash with the theme.

I started working on a script to patch the themes, attempting to fill in some missing colors based on existing one as well as make other corrections to contrast/readability. Unfortunately, the JSON files have duplicate keys. This was noted in #7, but the defect was not resolved in the subsequent releases. Since these duplicate keys often have different values, it is hard to know which color was intended.

[matthewjamesadam]

I really like Rainglow, it would be great to get the themes updated for the newer VSCode features. I'd love to file a PR to fix this, but (as per #7 ) it sounds like the originating data and scripts for the themes is not publicly available or modifiable. @daylerees is this correct? If so, is this something you'd consider opening up, so that the community can pitch in on these themes? Thanks for making rainglow!

[seraku24]

@matthewjamesadam, I wanted to briefly follow up as I had completely forgotten I had opened this issue. It's kind of a fun surprise when a GitHub email pops up in your inbox. The other day I learned a PR I had submitted to another VSCode-related project a couple years back was finally accepted.

Unfortunately, I never made much further progress on trying to patch this theme pack as I noted in my comment above. At the end of the day, I just went back to another color theme I had used before and pushed this work to the back burner. The bulk of the work I was doing was around automating the process, due to the shear number of themes included. At this point, I think you have the right idea of wanting to look at how the theme pack as it is gets generated. If I recall, there were several inconsistencies with how some of the themes had been generated. So, my attempt to patch things first needed to resolve these inherent issues before I could then extend the themes to the new colors defined in Code. And all of that work was long enough ago that I am certain there are more colors defined now that would need to be handled.

So, I must apologize I will probably be unable to offer more help myself—currently fighting some health issues which steal time and energy—but I wish you good luck if you are able to push this effort forward.