preserve order when generating CSV

Author: pcai

lib/rails_admin/support/csv_converter.rb

@@ -71,13 +71,22 @@ def export_field_for(method, model_config = @model_config)
 
     def generate_csv_string(options)
       generator_options = (options[:generator] || {}).symbolize_keys.delete_if { |_, value| value.blank? }
-      method = @objects.respond_to?(:find_each) ? :find_each : :each
 
       CSV.generate(**generator_options) do |csv|
         csv << generate_csv_header unless options[:skip_header]
 
-        @objects.send(method) do |object|
-          csv << generate_csv_row(object)
+        if @objects.respond_to?(:page)
+          page_num = 1
+          batch = @objects.page(page_num)
+          while batch.any?
+            batch.each { |object| csv << generate_csv_row(object) }
+            page_num += 1
+            batch = @objects.page(page_num)
+          end
+        else
+          @objects.each do |object|
+            csv << generate_csv_row(object)
+          end
         end
       end
     end

spec/rails_admin/support/csv_converter_spec.rb

@@ -151,5 +151,32 @@
         expect(subject[2]).to eq("\n")
       end
     end
+
+    context 'when more than one page of objects' do
+      before do
+        FactoryBot.create_list :player, 100
+      end
+
+      let(:objects) { Player.all }
+      let(:options) { {} }
+
+      it 'generates a csv with all objects' do
+        expect(subject[2].split("\n").count).to be 101
+      end
+    end
+
+    context 'when objects are ordered' do
+      before do
+        FactoryBot.create_list :player, 30
+        FactoryBot.create :player, name: 'Player zzz'
+      end
+
+      let(:objects) { Player.all.order('name desc') }
+      let(:options) { {} }
+
+      it 'preserves the ordering' do
+        expect(subject[2].split("\n")[1]).to include('Player zzz')
+      end
+    end
   end
 end