Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues running on MSSQL #493

Closed
janpieterz opened this issue Jan 22, 2025 · 1 comment
Closed

Issues running on MSSQL #493

janpieterz opened this issue Jan 22, 2025 · 1 comment

Comments

@janpieterz
Copy link

janpieterz commented Jan 22, 2025

We have noticed two issues so far:

activerecord-7.2.2.1/lib/active_record/insert_all.rb:179:in `ensure_valid_options_for_connection!': ActiveRecord::ConnectionAdapters::SQLServerAdapter does not support skipping duplicates (ArgumentError)
SolidQueue-1.1.2 Error in thread (0.0ms)  error: "ActiveRecord::StatementInvalid TinyTds::Error: ORDER BY items must appear in the select list if SELECT DISTINCT is specified

Happy to investigate at least an attempt to fix some of these. Would there be interest in merging in support?

@rosa
Copy link
Member

rosa commented Jan 28, 2025

Hey @janpieterz, MSSQL is not supported at the moment. and support for it is not planned, as it's not officially supported by Rails. However, I'd be happy to review a PR that addresses all problems, given that it's not overly complicated or affects the existing implementation for the other adapters.

@rosa rosa closed this as completed Feb 3, 2025
@rosa rosa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants