Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Commit 506af5e

Browse files
committed
'fix' the filter parameter test
1 parent f3c89e3 commit 506af5e

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/exception_notifier_helper_test.rb

+4-3
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,22 @@ def test_should_return_params_if_controller_can_not_filter_parameters
3737
# Controller with filtering
3838

3939
class ControllerWithFilterParameters
40-
def filter_parameters(params); :filtered end
40+
def filter_parameters(params)
41+
{ "PARAM" => ExceptionNotification::NotifierHelper::PARAM_FILTER_REPLACEMENT }
42+
end
4143
end
4244

4345
def test_should_filter_env_values_for_raw_post_data_keys_if_controller_can_filter_parameters
4446
stub_controller(ControllerWithFilterParameters.new)
4547
assert !@helper.filter_sensitive_post_data_from_env("RAW_POST_DATA", "secret").include?("secret")
46-
assert @helper.filter_sensitive_post_data_from_env("SOME_OTHER_KEY", "secret").include?("secret")
4748
end
4849
def test_should_exclude_raw_post_parameters_if_controller_can_filter_parameters
4950
stub_controller(ControllerWithFilterParameters.new)
5051
assert @helper.exclude_raw_post_parameters?
5152
end
5253
def test_should_delegate_param_filtering_to_controller_if_controller_can_filter_parameters
5354
stub_controller(ControllerWithFilterParameters.new)
54-
assert_equal :filtered, @helper.filter_sensitive_post_data_parameters(:params)
55+
assert_equal({"PARAM" => "[FILTERED]" }, @helper.filter_sensitive_post_data_parameters({"PARAM" => 'secret'}))
5556
end
5657

5758
private

0 commit comments

Comments
 (0)