diff --git a/python/uff_ssd/utils/model.py b/python/uff_ssd/utils/model.py index 11929de..c76a0ad 100644 --- a/python/uff_ssd/utils/model.py +++ b/python/uff_ssd/utils/model.py @@ -258,7 +258,26 @@ def download_model(model_name, silent=False): download_file(model_url, model_archive_path, silent) maybe_print(not silent, "Download complete\nUnpacking {}".format(model_archive_path)) with tarfile.open(model_archive_path, "r:gz") as tar: - tar.extractall(path=model_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=model_dir) maybe_print(not silent, "Extracting complete\nRemoving {}".format(model_archive_path)) os.remove(model_archive_path) maybe_print(not silent, "Model ready")